1632947 - Noticeable 5+ second delays when rendering email content containing link to google doc (Nightly)

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, defect, P1)

Description

[Rachel Tublitz [:rachel]]

Attachment: rendering_delay.gif

I've noticed this for the past 2-3 days in Nightly. Testing today against 77.0a1 (2020-04-24) (64-bit).

I'm not sure if this is a gmail issue, or a FF rendering issue. Tried to repro in Chrome, could not. Figured I'd file a bug just in case it's something in Nightly.

STR:

Using a gmail account...

1. Tag yourself in a Google doc (to trigger Google to send you an email notification about it).
2. Wait for the notification email to appear in your inbox in Gmail in Nightly.
3. Open the email. See the outer contents of the page render, but notice a long (I'm seeing 5+ seconds) delay before the actual email contents render.

ER:

Contents render at the same time.

AR:

Very long noticeable delay for embedded google docs within Gmail.

Comment 1

[Kershaw Chang [:kershaw]]

I've used mozregression and found the regression range below.

6:19.39 INFO: Narrowed nightly regression window from [2020-04-19, 2020-04-21] (2 days) to [2020-04-20, 2020-04-21] (1 days) (~0 steps left)
 6:19.39 INFO: Got as far as we can go bisecting nightlies...
 6:19.39 INFO: Last good revision: 272e82616218411bfb0b89ef7c710cd65830ece1 (2020-04-20)
 6:19.39 INFO: First bad revision: 263963426b561b2aa687aeeaeddc4fd93fff9e57 (2020-04-21)
 6:19.39 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=272e82616218411bfb0b89ef7c710cd65830ece1&tochange=263963426b561b2aa687aeeaeddc4fd93fff9e57

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Thanks for that Kershaw!
I reduced it even further to:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=06366bae59660d6019a3f5bb08f0c618cf6a2ab9&tochange=926129b605cd279ee58c6647ed5cd0368a1cf9f6

Looking at the code, it seems to be bug 1629926 at fault (a webcompat intervention for the microphone in gmail)

Comment 3

[Valentin Gosu [:valentin] (he/him)]

[Tracking Requested - why for this release]:

Marking affected based on the uplift to beta in bug 1625222

Comment 4

[Nhi Nguyen (:nhi)]

moved to Web Compat: Interventions based on bug 1625222.

Comment 5

[Mike Taylor [:miketaylr]]

Ksenia, can you take a look?

Comment 6

[Johann Hofmann [:johannh]]

Huh, I can't reproduce this at all. Can someone who can reproduce this create a perf profile, please?

Mike, Ksenia, can you take a look, please? Are you able to reproduce this issue? Can you profile it? I'm not sure why overriding the src attribute setter for iframes would create such an overhead but maybe we need to do further optimization here...

Comment 7

[Mike Taylor [:miketaylr]]

(Yeah, ksenia can repro and is working on a patch right now)

Comment 8

[Ksenia Berezina [:ksenia]]

Attachment: Bug 1632947 - Fix to hangouts microphone intervention.r=webcompat-reviewers,twisniewski

Comment 9

[Ksenia Berezina [:ksenia]]

The patch fixes the delay. Since https://bugzilla.mozilla.org/show_bug.cgi?id=1625222 has shipped to beta already, what are our options here, Ryan?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

I've already built the RC, so unless there's a respin later this week, we're shipping with 10.0. This is a system addon - can't we just update this via Balrog?

Comment 11

[Ksenia Berezina [:ksenia]]

Thanks, I've created a separate bug for that

Comment 12

[Mike Taylor [:miketaylr]]

Note: if this bug is affecting someone significantly, you can go to about:compat and disable the "GMail Hangouts microphone fix" intervention. It will only stay disabled until you re-start the browser though.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06d46637e5c7
Fix to hangouts microphone intervention.r=webcompat-reviewers,twisniewski

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/06d46637e5c7

Comment 15

[Mike Taylor [:miketaylr]]

Comment on attachment 9143820 [details]
Bug 1632947 - Fix to hangouts microphone intervention.r=webcompat-reviewers,twisniewski

Requesting uplift to beta + release for folks that have updates disabled.

This patch should be uplifted before Bug 1633838.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9143820 [details]
Bug 1632947 - Fix to hangouts microphone intervention.r=webcompat-reviewers,twisniewski

Needed for bug 1633838 and effectively a no-op since we're going to be shipping the 10.1.2 SAO update via Balrog to release users anyway. Approved for release to ride-along in any subsequent respins or dot releases as well.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a67c3808daa8