Closed Bug 1633031 Opened 9 months ago Closed 5 months ago

Support pushing and splitting flex items for multi-line column-oriented flex containers

Categories

(Core :: Layout: Flexbox, task, P3)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [layout:backlog])

Attachments

(3 files)

To break the scope of bug 939897, we plan to support shifting or splitting flex items for multi-line column-oriented flex containers in this bug.

nit: "pushing" is the term we use internally, so it's probably better to continue using that instead of "shifting" to avoid confusion.

Summary: Support shifting and splitting flex items on multi-line column-oriented flex containers → Support pushing and splitting flex items for multi-line column-oriented flex containers

Although this goes against the suggestion of sample algorithm in the
spec, this brings the layout of the multi-line column-oriented flex
container in paginated context closer to the layout with no
fragmentation. This is also matches Google Chrome's behavior.

Tweak flexbox-unbreakable-child-2.html so that it matches the rendering
as of this patch. Change the height of .muticol and the removal of
border in flexContainer to let two flex items exactly fit the flex
container's height, making reference easier to write.

We do the flex algorithm by assuming the available block-size is
unconstrained. Thus, we can remove availableBSizeForContent and
aStatus passing to DoFlexLayout(), ComputeMainSize(), and
ComputeCrossSize().

Depends on D87108

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Attachment #9170082 - Attachment description: Bug 1633031 Part 2 - Add reftest for fragmenting multi-line column-oriented flex containers. → Bug 1633031 Part 2 - Add reftests for fragmenting multi-line column-oriented flex containers.
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b1220dc3ec09
Part 1 - Stop considering available block-size when wrapping flex lines in multi-line column-oriented flex container. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/cd972e86c6d5
Part 2 - Add reftests for fragmenting multi-line column-oriented flex containers. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/fee27d9109bb
Part 3 - Remove unused parameters from DoFlexLayout(), ComputeMainSize(), and ComputeCrossSize(). r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.