1633037 - Remove all remaining references to $(PYTHON) across Makefiles

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1633037 - Remove all remaining references to $(PYTHON) across Makefiles

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9904cbc40d9
Remove all remaining references to $(PYTHON) across Makefiles r=glandium

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a9904cbc40d9

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 6 changesets (bug 1632916, bug 1599658, bug 1633037, bug 1633039, bug 1633016, bug 1632920) for SA bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Md5eFYLVTkaNzJ_njGqo0Q-0&searchStr=static-analysis-autotest&fromchange=c7a7b7056257586a7c07f8864de3cc3d64c76eac&tochange=1e7acd6af3ee39f1ef2e6db60ca8ec1f08685f46

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e7acd6af3ee39f1ef2e6db60ca8ec1f08685f46

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300436002&repo=autoland&lineNumber=1746

...
[task 2020-05-01T22:26:16.170Z] RUNNING: clang-tidy checker readability-uniqueptr-delete-release.
[task 2020-05-01T22:26:16.210Z] Error running mach:
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z]     ['--log-no-times', 'static-analysis', 'autotest', '--intree-tool']
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] The error occurred in code that was called by the mach command. This is either
[task 2020-05-01T22:26:16.210Z] a bug in the called code itself or in the way that mach is calling it.
[task 2020-05-01T22:26:16.210Z] You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2020-05-01T22:26:16.210Z] isn't, please use |./mach busted file| to report it. If |./mach busted| is
[task 2020-05-01T22:26:16.210Z] misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] If filing a bug, please include the full output of mach, including this error
[task 2020-05-01T22:26:16.210Z] message.
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] The details of the failure are as follows:
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] OSError: [Errno 2] No such file or directory
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 1177, in autotest
[task 2020-05-01T22:26:16.210Z]     ret_val = future.result()
[task 2020-05-01T22:26:16.210Z]   File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/_base.py", line 398, in result
[task 2020-05-01T22:26:16.211Z]     return self.__get_result()
[task 2020-05-01T22:26:16.211Z]   File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/thread.py", line 55, in run
[task 2020-05-01T22:26:16.211Z]     result = self.fn(*self.args, **self.kwargs)
[task 2020-05-01T22:26:16.211Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 1724, in _verify_checker
[task 2020-05-01T22:26:16.211Z]     checks='-*,' + check, header_filter='', sources=[test_file_path_cpp])
[task 2020-05-01T22:26:16.212Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 1246, in _run_analysis
[task 2020-05-01T22:26:16.212Z]     clang_output = subprocess.check_output(cmd, stderr=subprocess.STDOUT).decode('utf-8')
[task 2020-05-01T22:26:16.212Z]   File "/usr/lib/python2.7/subprocess.py", line 212, in check_output
[task 2020-05-01T22:26:16.212Z]     process = Popen(stdout=PIPE, *popenargs, **kwargs)
[task 2020-05-01T22:26:16.212Z]   File "/usr/lib/python2.7/subprocess.py", line 390, in __init__
[task 2020-05-01T22:26:16.213Z]     errread, errwrite)
[task 2020-05-01T22:26:16.213Z]   File "/usr/lib/python2.7/subprocess.py", line 1024, in _execute_child
[task 2020-05-01T22:26:16.213Z]     raise child_exception
[task 2020-05-01T22:26:16.236Z] 22:26:16  WARNING - setting return code to 2
[task 2020-05-01T22:26:16.236Z] 22:26:16    FATAL - 'mach static-analysis autotest --intree-tool' did not run successfully. Please check log for errors.
[task 2020-05-01T22:26:16.237Z] 22:26:16    FATAL - Running post_fatal callback...
[task 2020-05-01T22:26:16.237Z] 22:26:16    FATAL - Exiting -1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebd776fd9088
Remove all remaining references to $(PYTHON) across Makefiles r=glandium

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ebd776fd9088

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebd776fd9088
Remove all remaining references to $(PYTHON) across Makefiles r=glandium

One of your patches in this changeset cause the below regression, but it was eventually fixed.
== Change summary for alert #25936 (as of Thu, 14 May 2020 14:51:43 GMT) ==

Regressions:

52% build times linux64 asan debug taskcluster-c5d.4xlarge 1,064.79 -> 1,622.73

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25936