Closed Bug 1633037 Opened 4 years ago Closed 3 years ago

Remove all remaining references to $(PYTHON) across Makefiles


(Firefox Build System :: General, task)



(firefox78 fixed)

Tracking Status
firefox78 --- fixed


(Reporter: rstewart, Assigned: rstewart)



(Keywords: perf-alert)


(1 file)

No description provided.
Pushed by
Remove all remaining references to $(PYTHON) across Makefiles r=glandium
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Backed out 6 changesets (bug 1632916, bug 1599658, bug 1633037, bug 1633039, bug 1633016, bug 1632920) for SA bustages

Push with failures:

Backout link:

Failure log:

[task 2020-05-01T22:26:16.170Z] RUNNING: clang-tidy checker readability-uniqueptr-delete-release.
[task 2020-05-01T22:26:16.210Z] Error running mach:
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z]     ['--log-no-times', 'static-analysis', 'autotest', '--intree-tool']
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] The error occurred in code that was called by the mach command. This is either
[task 2020-05-01T22:26:16.210Z] a bug in the called code itself or in the way that mach is calling it.
[task 2020-05-01T22:26:16.210Z] You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2020-05-01T22:26:16.210Z] isn't, please use |./mach busted file| to report it. If |./mach busted| is
[task 2020-05-01T22:26:16.210Z] misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] If filing a bug, please include the full output of mach, including this error
[task 2020-05-01T22:26:16.210Z] message.
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] The details of the failure are as follows:
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z] OSError: [Errno 2] No such file or directory
[task 2020-05-01T22:26:16.210Z] 
[task 2020-05-01T22:26:16.210Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code-analysis/", line 1177, in autotest
[task 2020-05-01T22:26:16.210Z]     ret_val = future.result()
[task 2020-05-01T22:26:16.210Z]   File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/", line 398, in result
[task 2020-05-01T22:26:16.211Z]     return self.__get_result()
[task 2020-05-01T22:26:16.211Z]   File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/", line 55, in run
[task 2020-05-01T22:26:16.211Z]     result = self.fn(*self.args, **self.kwargs)
[task 2020-05-01T22:26:16.211Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code-analysis/", line 1724, in _verify_checker
[task 2020-05-01T22:26:16.211Z]     checks='-*,' + check, header_filter='', sources=[test_file_path_cpp])
[task 2020-05-01T22:26:16.212Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code-analysis/", line 1246, in _run_analysis
[task 2020-05-01T22:26:16.212Z]     clang_output = subprocess.check_output(cmd, stderr=subprocess.STDOUT).decode('utf-8')
[task 2020-05-01T22:26:16.212Z]   File "/usr/lib/python2.7/", line 212, in check_output
[task 2020-05-01T22:26:16.212Z]     process = Popen(stdout=PIPE, *popenargs, **kwargs)
[task 2020-05-01T22:26:16.212Z]   File "/usr/lib/python2.7/", line 390, in __init__
[task 2020-05-01T22:26:16.213Z]     errread, errwrite)
[task 2020-05-01T22:26:16.213Z]   File "/usr/lib/python2.7/", line 1024, in _execute_child
[task 2020-05-01T22:26:16.213Z]     raise child_exception
[task 2020-05-01T22:26:16.236Z] 22:26:16  WARNING - setting return code to 2
[task 2020-05-01T22:26:16.236Z] 22:26:16    FATAL - 'mach static-analysis autotest --intree-tool' did not run successfully. Please check log for errors.
[task 2020-05-01T22:26:16.237Z] 22:26:16    FATAL - Running post_fatal callback...
[task 2020-05-01T22:26:16.237Z] 22:26:16    FATAL - Exiting -1
Flags: needinfo?(rstewart)
Resolution: FIXED → ---
Target Milestone: mozilla77 → ---
Flags: needinfo?(rstewart)
Pushed by
Remove all remaining references to $(PYTHON) across Makefiles r=glandium
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Regressions: 1635750

(In reply to Pulsebot from comment #5)

Pushed by
Remove all remaining references to $(PYTHON) across Makefiles r=glandium

One of your patches in this changeset cause the below regression, but it was eventually fixed.
== Change summary for alert #25936 (as of Thu, 14 May 2020 14:51:43 GMT) ==


52% build times linux64 asan debug taskcluster-c5d.4xlarge 1,064.79 -> 1,622.73

For up to date results, see:

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.