Fix/enable ESLint react/prop-types
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: camd, Assigned: bolah2009)
Details
Attachments
(1 file)
We should fix the violations and enable this rule.
Assignee | ||
Comment 1•5 years ago
|
||
I would like to work on it if that's okay.
Reporter | ||
Comment 2•5 years ago
|
||
Bola-- So sorry I had such a slow response to you on this! Yes, please work on this. That would be very much appreciated! :)
Assignee | ||
Comment 3•5 years ago
|
||
Thanks, Cameron, I already started working on it pending your response.
However, the errors are many (500+) and span various files. Is it okay to open a single PR for this?
Assignee | ||
Comment 4•5 years ago
|
||
The list of files (31) that have been modified so far with 300+ errors left:
- ui/intermittent-failures/GraphAlternateView.jsx
- ui/job-view/CustomJobActions.jsx
- ui/job-view/KeyboardShortcuts.jsx
- ui/job-view/details/BugFiler.jsx
- ui/job-view/details/DetailsPanel.jsx
- ui/job-view/details/PinBoard.jsx
- ui/job-view/details/summary/ActionBar.jsx
- ui/job-view/details/summary/ClassificationsPanel.jsx
- ui/job-view/details/summary/LogItem.jsx
- ui/job-view/details/summary/StatusPanel.jsx
- ui/job-view/details/summary/SummaryPanel.jsx
- ui/job-view/details/tabs/AnnotationsTab.jsx
- ui/job-view/details/tabs/SimilarJobsTab.jsx
- ui/job-view/details/tabs/TabsPanel.jsx
- ui/job-view/details/tabs/failureSummary/BugListItem.jsx
- ui/job-view/details/tabs/failureSummary/FailureSummaryTab.jsx
- ui/job-view/details/tabs/failureSummary/SuggestionsListItem.jsx
- ui/job-view/headerbars/ActiveFilters.jsx
- ui/job-view/headerbars/FiltersMenu.jsx
- ui/job-view/headerbars/SecondaryNavBar.jsx
- ui/job-view/headerbars/TierIndicator.jsx
- ui/job-view/headerbars/TiersMenu.jsx
- ui/job-view/pushes/JobButton.jsx
- ui/job-view/pushes/JobGroup.jsx
- ui/job-view/pushes/Platform.jsx
- ui/job-view/pushes/Push.jsx
- ui/job-view/pushes/PushHeader.jsx
- ui/job-view/pushes/PushLoadErrors.jsx
- ui/shared/JobInfo.jsx
- ui/shared/Revision.jsx
- ui/shared/RevisionList.jsx
Reporter | ||
Comment 5•4 years ago
|
||
Wow, that IS a lot. :) One PR will be fine, yes. It's a lot, true. But that's ok. Please either assign me to the PR when ready, or need-info me here again and I'll review it. Thanks!!
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
I opened a PR for this.
I couldn't assign you to the PR, so am using the need-info as an alternative. Thanks!
Comment 9•2 years ago
|
||
I assume this is done
Description
•