Closed Bug 1633059 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23245 - Replace assert_precondition in workers/

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23245 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23245
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:

Replace assert_precondition in workers/

assert_precondition is deprecated (see
https://github.com/web-platform-tests/rfcs/blob/master/rfcs/assert_precondition_rename.md).

PR 23245 applied with additional changes from upstream: 603ea91ccada76c2796bc51d1cf027882582cd83, f6f6077aab9fea53099084cd009e0701ca5dcfa7, d3339d0d109fbcf9978c856ed1ce74621b914675

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 68 tests

Status Summary

Firefox

PASS : 67
ERROR : 1
NOTRUN: 2

Chrome

OK : 1
PASS : 2

Safari

ERROR : 1
NOTRUN: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/workers/modules/dedicated-worker-parse-error-failure.html: ERROR (Chrome: OK, Safari: ERROR)
Module worker construction for script with syntax error should dispatch an event named error.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Static import on module worker for script with syntax error should dispatch an event named error.: NOTRUN (Chrome: PASS, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3318c19a1642
[wpt PR 23245] - Replace assert_precondition in workers/, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d700bf57b90b
[wpt PR 23245] - Replace assert_precondition in workers/, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d700bf57b90b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.