[wpt-sync] Sync PR 23249 - Fix a null reference in declarative shadow dom
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 23249 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23249
Details from upstream follow.
Mason Freed <masonfreed@chromium.org> wrote:
Fix a null reference in declarative shadow dom
Previously, this would cause a null-reference:
\<template shadowroot=open>Content\</template>
This is now fixed. In addition, this CL adds two more tests of
declarative shadow dom, for the two conditions listed at [1] and
[2]. The [2] condition test also tests this CL.[1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#root-element-is-template-shadowroot
[3] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#templates-containing-root-level-declarative-shadow-rootsBug: 1042130
Change-Id: Id697fb3f89681981ca3ecc513451d0644430fd2b
Reviewed-on: https://chromium-review.googlesource.com/2166357
WPT-Export-Revision: afd67dd1d9f7a4c739b10081641345b66751ac09
Assignee | ||
Comment 1•4 years ago
|
||
PR 23249 applied with additional changes from upstream: f8bfad9f31e64b909d850df59202a02edb3d89ac, 13868f2aa3ff16f7f338d492e0027c301f07f74c
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c7f230f808348ac48a01e75eb56afc64f70df78
Assignee | ||
Comment 3•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 68 tests
Status Summary
Firefox
OK : 1
PASS : 3[GitHub] 70[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 6
Chrome
CRASH: 1
Safari
OK : 1
PASS : 3
FAIL : 6
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/shadow-dom/declarative/declarative-shadow-dom-basic.tentative.html
Declarative Shadow DOM: Missing closing tag: FAIL (Safari: FAIL)
Declarative Shadow DOM: Fragment parser basic test: FAIL (Safari: FAIL)
Declarative Shadow DOM: delegates focus attribute: FAIL (Safari: FAIL)
Declarative Shadow DOM: Multiple roots: FAIL (Safari: FAIL)
Declarative Shadow DOM: Closed shadow root attribute: FAIL (Safari: FAIL)
Declarative Shadow DOM: Basic test: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7dc0328ced91 [wpt PR 23249] - Fix a null reference in declarative shadow dom, a=testonly
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/45e00e084ed0 [wpt PR 23249] - Fix a null reference in declarative shadow dom, a=testonly
Comment 6•4 years ago
|
||
bugherder |
Description
•