1633195 - Find function hits on text across <br> boundary when followed by <strong>

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[digikata]

Attachment: find-bug-example.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Searched for a string "CA" for the state on https://www.debian.org/consultants/#US, and found lots of hits on address lines that ended with "C", and a new line starting with a <strong> emphasized "Address"

Actual results:

find for "CA" had lots of hits on address lines that ended with "C", and a new line starting with a <strong> emphasized "Address"

Expected results:

File attached, but searching for "CA"
wordC<br> Address
doesn't get found while
wordC<br> <strong>Address</strong>
does get found.

It seems like at least one is unintended. Probably neither case should be found.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alice0775 White]

STR

1. Open attached
2. Find in page with "ac"

Expected results: not found

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6272dd5e7417adf68255abfb1d691a36e5a2d6e8&tochange=3931f461c8e8668a264d52b51a4524aac39a7a16

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah, I think this is a result of those patches, though apparently it used to work mostly by chance. In the <strong> case layout manages to suppress the whitespace that goes in between the <br> and the <strong>.

But this is an issue without that: data:text/html,a<br>b. Anyhow happy to poke at it.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1633195 - Make sure <br> forces a break even if there's no whitespace in between. r=jfkthame

Wrote this on top of bug 1627643. Should be easy to rebase if needed,
though.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebb5b2a2d790
Make sure <br> forces a break even if there's no whitespace in between. r=jfkthame

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ebb5b2a2d790