Closed
Bug 1633222
Opened 4 years ago
Closed 4 years ago
Cleanup js::jit::alignDoubleSpillWithOffset
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
The js::jit::alignDoubleSpillWithOffset helper is to support some mips-32 alignment requirements, but as-written it is hard to follow.
|
Assignee | |
Comment 1•4 years ago
|
||
This exists for mips-32 targets which expect double values to be 8-byte
aligned. This patch removes the offset argument which was misleading.
Instead a alignedForABI method is added to the ExitFrameFooter type. This
skips over additional padding added in the MIPS32 trampolines.
Depends on D72548
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24af87fb0f32 Cleanup js::jit::alignDoubleSpillWithOffset. r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•