1633286 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/media

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P3)

Description

[Chris Peterson [:cpeterson]]

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Comment 1

[Chris Peterson [:cpeterson]]

Oops! I accidentally landed this bug's patches linking to the wrong bug number:

https://bugzilla.mozilla.org/show_bug.cgi?id=1594529#c40

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1589fcd0929c
Replace MOZ_MUST_USE with [[nodiscard]] in dom/media/webaudio. r=padenot
https://hg.mozilla.org/integration/autoland/rev/63a755d0e9b1
Replace MOZ_MUST_USE with [[nodiscard]] in dom/media. r=bryce