Closed
Bug 1633301
Opened 4 years ago
Closed 4 years ago
[mozdevice] ADBDevice.rm should raise an error if the target was not deleted.
Categories
(Testing :: Mozbase, defect)
Tracking
(firefox77 fixed)
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
ADBDevice.rm catches ADBError and checks if force=True and if the error is 'No such file or directory' in order to ignore such errors when force is specified. However, this loses the error when it was not possible to delete the target. This can happen when a profile directory contains content owned by the Firefox app and which can not be deleted by the shell process unless we execute it as root.
This issue does not appear to affect rmdir since it does not attempt to filter the ADBError exceptions.
This was discovered during the process or working on bug 1632959.
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D72575
Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2ecc5032c91 [mozdevice] ADBDevice.rm should raise an error if the target was not deleted, r=gbrown.
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•