WalkerFront should only retrieve the root node via actor events
Categories
(DevTools :: Inspector, task, P3)
Tracking
(Fission Milestone:Future)
Fission Milestone | Future |
People
(Reporter: jdescottes, Unassigned)
References
Details
(Whiteboard: dt-fission-future)
Currently the Walker front reads the root node from:
- form() https://searchfox.org/mozilla-central/rev/55a4faa52f72918efa51150d127aebdc057dc6cf/devtools/client/fronts/walker.js#40
- newRoot mutations https://searchfox.org/mozilla-central/rev/55a4faa52f72918efa51150d127aebdc057dc6cf/devtools/client/fronts/walker.js#255
This will be slightly simplified by bug 1611096 and the walker front will use a watch-like API in order to retrieve the root NodeFront. This should replace completely both the form
and the mutation mentioned above.
However, by default the walker front is not watching for root nodes, and some tests are relying on the fact that it automatically reads the root node front within form() to work.
We could either make those tests explicitly ask the walker to watch, or make the walker watch by default.
See the current landscape of failures when removing the rootNode assignment in form():
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9857f5088f577f98024b9bf77b7a09da0a381a24
The work to move this to a regular watch API might also change how we start/stop watching for this resource (Bug 1625961)
Comment 1•4 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
Comment 2•4 years ago
|
||
dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.
Comment 3•4 years ago
|
||
Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.
Comment 4•3 years ago
|
||
Moving old "dt-fission-m2-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.
Description
•