1633451 - Turn the layout.reflow.synthMouseMove pref back off

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

See discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1545393#c5 onwards. I filed bug 1633450 for fixing this better in Gecko but for now we should turn the pref back off.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1633451 - Re-disable synthetic mousemoves on Android. r?#geckoview-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b73e8e74ebf
Re-disable synthetic mousemoves on Android. r=geckoview-reviewers,m_kato

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failure on pointerevent_lostpointercapture_for_disconnected_node_in_shadow_dom.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/632035e7c6842ed4e525cdd124a22446ae1bb375
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299838550&repo=autoland&lineNumber=6880

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Looks like there are two pointerevents tests that are failing on Android. Both tests were added pretty recently (after this pref was turned on for Android), so I guess they rely on this synthetic mousemove event? Sigh.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Makoto, would you be ok with me marking the two tests as failing in order to land this? It's not clear to me why the tests are failing. I can do some investigation but it might take a few days.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

So it seems like if the pointer is captured on a shadow element and the element is removed from the DOM, we don't fire the lostpointercapture event unless the synthMouseMove pref is enabled. Presumably the synthetic mousemove is required to trigger the code that loses the pointer capture.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)

Makoto, would you be ok with me marking the two tests as failing in order to land this? It's not clear to me why the tests are failing. I can do some investigation but it might take a few days.

I guess a better solution is to just mark the pref true for those tests, since they appear to require it. I'll try that.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Try push with updated patch: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=Hx1jSDOmQZ-vXcN-KjRX-Q-0&revision=2c9db6a133c244c2fe8d72694190ab93f59eb9c2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee7ec2f4b97
Re-disable synthetic mousemoves on Android. r=geckoview-reviewers,m_kato

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8ee7ec2f4b97