Closed Bug 1633456 Opened 4 years ago Closed 3 months ago

`TelemetryStorage.addPendingPing` and `TelemetryStorage.savePendingPing` are identical

Categories

(Toolkit :: Telemetry, task, P5)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: chutten, Assigned: jing.harrell, Mentored)

Details

(Whiteboard: [good next bug][lang=JS])

Attachments

(2 files)

I think we should drop TelemetryStorage.addPendingPing since TelemetryController has its own version with meaningfully-different semantics. Then we can standardize on TelemetryStorage.savePendingPing.

Mentor: chutten
Severity: -- → N/A
Assignee: nobody → jing.harrell

Hi, I'm a new contributor, and I'll be submitting a patch for this issue soon

Hi Chris, I've run the tests inside toolkit/components/telemetry/tests/unit. Are there any other tests I need to run? Thanks.

Flags: needinfo?(chutten)

Nope! That ought to catch any failures as this change ought to be fairly low level, and that suite is fairly comprehensive at testing the units.

Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/002448412f97
Remove the `TelemetryStorage.addPendingPing` method. r=chutten
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: