Closed
Bug 1633464
Opened 4 years ago
Closed 4 years ago
Use a tail-call to enter the Ion invalidation trampoline
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
Details
Attachments
(1 file)
We currently generate a call and then immediately strip the return address off the stack. Instead we should just use a jump to simplify. Architectures with link-registers should also use a jmp, but they don't have the same stack traffic.
|
Assignee | |
Comment 1•4 years ago
|
||
On x86/x64 platforms, we were using a call and then immediately popping and
ignoring the return value, so use a jump instead. For architectures that use
a link-register, we no longer clobber it but it was already ignored.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2407418c8476 Use a jump to enter Ion invalidation trampoline. r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•