Closed Bug 1633514 Opened 4 years ago Closed 4 years ago

Rework test_paramSubstitution.js to work with WebExtensions rather than a manually added one

Categories

(Firefox :: Search, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 77
Iteration:
77.2 - Apr 20 - May 3
Tracking Status
firefox77 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(2 files)

I want to rewrite test_paramSubstitution.js as it currently uses a manually added test engine to check if MozParams are accessible or not.

As it is manually poking the engine object to pretend if it is a distribution/built-in, it doesn't really fit the requirements for what I need.

Hence, splitting out rewriting of it to this bug.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/266b32a268d5
Add SearchTestUtils.installSearchExtension to make testing search engine WebExtensions easier. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/e5f8075c881a
Rework test_paramSubstitution.js to work with WebExtensions rather than a manually added one. r=daleharvey

Backed out 3 changesets (Bug 1633514, Bug 1626410) for xpcshell failures xpcshell at components/extensions/test/xpcshell/test_ext_settings_overrides_search_mozParam.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=ZDm0o-NgSyioUCWAWtbDAw-0&searchStr=windows%2C7%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows7-32%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&revision=05d9a649538f534f531736de9680a5c9de5b37ca

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300020200&repo=autoland&lineNumber=6958

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=ZDm0o-NgSyioUCWAWtbDAw-0&searchStr=windows%2C7%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows7-32%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&revision=8c2a3462aba2f269f8131480e882a970c912c5fb

[task 2020-04-29T17:00:15.390Z] 17:00:15     INFO -  TEST-START | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_search_mozParam.js
[task 2020-04-29T17:00:18.529Z] 17:00:18  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_search_mozParam.js | xpcshell return code: 0
[task 2020-04-29T17:00:18.529Z] 17:00:18     INFO -  TEST-INFO took 3140ms
[task 2020-04-29T17:00:18.530Z] 17:00:18     INFO -  >>>>>>>
[task 2020-04-29T17:00:18.530Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 88
[task 2020-04-29T17:00:18.530Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 88
[task 2020-04-29T17:00:18.531Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 88
[task 2020-04-29T17:00:18.531Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 88
[task 2020-04-29T17:00:18.531Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 88
[task 2020-04-29T17:00:18.531Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 2919
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: This method is lossy. Use GetCanonicalPath !: file /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp, line 3301
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: This method is lossy. Use GetCanonicalPath !: file /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp, line 3301
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: This method is lossy. Use GetCanonicalPath !: file /builds/worker/checkouts/gecko/xpcom/io/nsLocalFileWin.cpp, line 3301
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  running event loop
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_settings_overrides_search_mozParam.js | Starting setup
[task 2020-04-29T17:00:18.532Z] 17:00:18     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2020-04-29T17:00:18.533Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Workers don't support the 'mem.mem.' preference!: file /builds/worker/checkouts/gecko/dom/workers/RuntimeService.cpp, line 519
[task 2020-04-29T17:00:18.533Z] 17:00:18     INFO -  PID 4436 | [4436, Main Thread] WARNING: Workers don't support the 'mem.mem.' preference!: file /builds/worker/checkouts/gecko/dom/workers/RuntimeService.cpp, line 519
[task 2020-04-29T17:00:18.534Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615789	addons.manager	DEBUG	Application has been upgraded"
[task 2020-04-29T17:00:18.534Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615790	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]"
[task 2020-04-29T17:00:18.534Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615800	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm"
[task 2020-04-29T17:00:18.534Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615804	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm"
[task 2020-04-29T17:00:18.534Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615805	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2020-04-29T17:00:18.534Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615805	addons.xpi	DEBUG	startup"
[task 2020-04-29T17:00:18.535Z] 17:00:18     INFO -  "CONSOLE_MESSAGE: (info) 1588179615806	addons.xpi	DEBUG	List of built-in add-ons is missing or invalid.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2394"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2394
[task 2020-04-29T17:00:18.535Z] 17:00:18     INFO -  callProvider()@resource://gre/modules/AddonManager.jsm:212
[task 2020-04-29T17:00:18.535Z] 17:00:18     INFO -  _startProvider()@resource://gre/modules/AddonManager.jsm:584
[task 2020-04-29T17:00:18.535Z] 17:00:18     INFO -  startup()@resource://gre/modules/AddonManager.jsm:808
[task 2020-04-29T17:00:18.536Z] 17:00:18     INFO -  startup()@resource://gre/modules/AddonManager.jsm:3479
[task 2020-04-29T17:00:18.536Z] 17:00:18     INFO -  observe()@resource://gre/modules/addonManager.js:87
[task 2020-04-29T17:00:18.536Z] 17:00:18     INFO -  promiseStartupManager()@resource://testing-common/AddonTestUtils.jsm:979
Flags: needinfo?(standard8)

Caused by the other bug, I'll re-land this part.

Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ee31b11809f
Add SearchTestUtils.installSearchExtension to make testing search engine WebExtensions easier. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/6f7323ce8225
Rework test_paramSubstitution.js to work with WebExtensions rather than a manually added one. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: