Closed Bug 1633522 Opened 5 years ago Closed 5 years ago

shutdown hang with "SessionFile is closed"

Categories

(Firefox :: Session Restore, task)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

I was looking through the logs for the shutdown hangs in bug 1358898.

I found an opt log where the stack for the main thread isn't junk: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298693343&repo=autoland&lineNumber=3820

Specifically, it is hanging when we're spinning the event loop in ContentParent::Observe(). (The idea is that we are waiting to process all of the work that shutting down a content process makes us do.)

Anyways, I noticed this error in the log:

INFO - GECKO(1871) | console.error: (new Error("SessionFile is closed", "resource:///modules/sessionstore/SessionFile.jsm", 433))

Then I looked at the other 4 recent shutdown hangs in mochitest 3, and they all had the same error. I looked at about 4 non-failing mochitest 3, and they didn't have that error. I also looked at 4 mochitest-2 runs that were also failing with shutdown hangs, and they also had the same error. Same with the 3 mochitest-plain-e10s-1 failures, and all but 1 of the mochitest-plain-e10s-4 failures.

Anyways, this could all just be a red herring. Perhaps if shutdown is taking a long time for some reason then session store ends up trying to write something too late. But I thought I'd file the bug in case there's something to go on.

I saw this error a lot while trying to reproduce the hangs locally, but never saw the actual hang, so I suspect it's unrelated.

Good to know. I tried making RunState.isClosing case of write() return a Promise.reject value, but it had no effect that I saw. I'll just close this.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.