Closed Bug 1633546 Opened 3 months ago Closed 3 months ago

[Dynamic FPI] ERROR dom/security/test/csp/test_service_worker.html - called finish() multiple times

Categories

(Core :: Privacy: Anti-Tracking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: xeonchen, Assigned: xeonchen)

References

Details

Attachments

(1 file)

The finish function is called twice because besides [0] is called in both network.cookie.cookieBehavior is 4 or 5 cases, [1] is also called when network.cookie.cookieBehavior=5.
In the latter case, it is called because storageAllowed is not allow and rejected reason is STATE_COOKIES_PARTITIONED_FOREIGN.

Chritoph, do you think we can simply ignore the second finish call at [2]?

[0] https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/dom/serviceworkers/ServiceWorkerContainer.cpp#346
[1] https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/dom/serviceworkers/ServiceWorkerContainer.cpp#644
[2] https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/dom/security/test/csp/file_service_worker.html#8-10

Flags: needinfo?(ckerschb)
Assignee: nobody → xeonchen

(In reply to Gary Chen [:xeonchen] from comment #1)

Chritoph, do you think we can simply ignore the second finish call at [2]?

If there is anything we could observe in that second (or also first case) then that would obviously be better for the stability of the test. If that's not possible then please add a comment explaining the change in detail. thanks!

Flags: needinfo?(ckerschb)
Attachment #9144281 - Attachment description: Bug 1633546 - accept `finish` callback only once; → Bug 1633546 - update testing results for network.cookie.cookieBehavior;
Priority: -- → P2
Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/609ba00edf3c
update testing results for network.cookie.cookieBehavior; r=ckerschb
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.