1633546 - [Dynamic FPI] ERROR dom/security/test/csp/test_service_worker.html - called finish() multiple times

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Gary Chen [:xeonchen]]

finish('blocked') is called twice at https://searchfox.org/mozilla-central/rev/158bac3df3a1890da55bdb6ffdaf9a7ffc0bfb0a/dom/security/test/csp/file_service_worker.html#13,16 when dFPI is enabled by default.

Failure task: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299273302&repo=try&lineNumber=2351

Comment 1

[Gary Chen [:xeonchen]]

The finish function is called twice because besides [0] is called in both network.cookie.cookieBehavior is 4 or 5 cases, [1] is also called when network.cookie.cookieBehavior=5.
In the latter case, it is called because storageAllowed is not allow and rejected reason is STATE_COOKIES_PARTITIONED_FOREIGN.

Chritoph, do you think we can simply ignore the second finish call at [2]?

[0] https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/dom/serviceworkers/ServiceWorkerContainer.cpp#346
[1] https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/dom/serviceworkers/ServiceWorkerContainer.cpp#644
[2] https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/dom/security/test/csp/file_service_worker.html#8-10

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1633546 - update testing results for network.cookie.cookieBehavior;

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Gary Chen [:xeonchen] from comment #1)

Chritoph, do you think we can simply ignore the second finish call at [2]?

If there is anything we could observe in that second (or also first case) then that would obviously be better for the stability of the test. If that's not possible then please add a comment explaining the change in detail. thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/609ba00edf3c
update testing results for network.cookie.cookieBehavior; r=ckerschb

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/609ba00edf3c