1633594 - [wpt-sync] Sync PR 23282 - [FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items.

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23282 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23282
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items.

Previously LayoutGrid was determining its height was indefinite within
a flexbox stretching it. This resulted in a zero sized grid.

This patch fixes both:
LayoutBlock::AvailableLogicalHeightForPercentageComputation
LayoutBox::AvailableLogicalHeightUsing
... to read the BoxLayoutExtraInput data-structure to correctly determine
the fixed inline/block sizes, and if the fixed block size should be
treated as definite.

Bug: 1074593
Change-Id: I0cb9401d9f4d93afa94726fcb30fa4a576b04142

Reviewed-on: https://chromium-review.googlesource.com/2167157
WPT-Export-Revision: b6aac60df2e4069616f499038aed9e0680667631

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=acc6801588cded15acf615c5d3bb48bf7c34fcea

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bb2e88875a5
[wpt PR 23282] - [FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cebd628b152
[wpt PR 23282] - [FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items., a=testonly

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3cebd628b152