Closed Bug 1633594 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23282 - [FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items.

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23282 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23282
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items.

Previously LayoutGrid was determining its height was indefinite within
a flexbox stretching it. This resulted in a zero sized grid.

This patch fixes both:
LayoutBlock::AvailableLogicalHeightForPercentageComputation
LayoutBox::AvailableLogicalHeightUsing
... to read the BoxLayoutExtraInput data-structure to correctly determine
the fixed inline/block sizes, and if the fixed block size should be
treated as definite.

Bug: 1074593
Change-Id: I0cb9401d9f4d93afa94726fcb30fa4a576b04142

Reviewed-on: https://chromium-review.googlesource.com/2167157
WPT-Export-Revision: b6aac60df2e4069616f499038aed9e0680667631

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bb2e88875a5
[wpt PR 23282] - [FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3cebd628b152
[wpt PR 23282] - [FlexNG] Fix AvailableLogicalHeight calculations for legacy flex-items., a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.