1633602 - Ship webcompat addon v10.1.2 sources via SAO update

Status: RESOLVED WONTFIX

(Web Compatibility :: Interventions, task, P1)

Description

[Ksenia Berezina [:ksenia]]

There is a report that an existing hangouts intervention on gmail is causing a delay when rendering email content containing link to google doc https://bugzilla.mozilla.org/show_bug.cgi?id=1632947

We need to verify that the issue is fixed and ship the update via barlog

Comment 1

[Ksenia Berezina [:ksenia]]

Attachment: webcompat-10.1.1.unsigned.xpi

Comment 2

[Mike Taylor [:miketaylr]]

Wei, can we please get webcompat-10.1.1.unsigned.xpi signed as a system addon (Mozilla Components key)? Then we'll ni? QA for testing.

edit: we've verified the fix internally.

Comment 3

[Mike Taylor [:miketaylr]]

(We would like to get this addon to ship via Balrog because it fixes a performance regression in gmail (Bug 1632947), and we'd have to delay the 76 release otherwise.)

Comment 4

[Mike Taylor [:miketaylr]]

(I'm not sure we need to track the 76 release for a SAO update, feel free to clear the flag)

Comment 5

[Mike Taylor [:miketaylr]]

Hang tight. We need to update the addon, because gmail apparently fixed the bug today (yay for timing), so we can just remove the intervention.

Comment 6

[Mike Taylor [:miketaylr]]

(Updating title to reflect a version change to avoid any possible version mismatch bugs since v10.1.1 is already on autoland)

Comment 7

[Ksenia Berezina [:ksenia]]

Attachment: webcompat-10.1.2.unsigned.xpi

Comment 8

[Mike Taylor [:miketaylr]]

OK, I've verified webcompat-10.1.2.unsigned.xpi locally (again). Wei, can we get it signed as a system addon (Mozilla Components key) for QA to test please?

Comment 9

[:wezhou]

Attachment: signed.9144082.xpi

Signed file attached. Please test it.

Comment 10

[Mike Taylor [:miketaylr]]

Oana, can you please test the signed addon in a 76 build? The test scenario is sort of silly because Google fixed this a few hours ago, but basically the test plan will look like this:

1. Open 76 build (not Nightly because the next Nightly will have removed the code this XPI removes via Bug 1633838)
2. open about:compat and look for the "GMail Hangouts microphone fix" intervention
3. Close about:compat
4. Install signed XPI from Comment #9
5. open about:compat and verify the "GMail Hangouts microphone fix" intervention is no longer there.

edit: if about:compat gets into a weird (blank) state, that's expected. It will be normal after a restart.

Comment 11

[Oana Arbuzov [:oanaarbuzov]]

Mike, I can confirm that after installing "signed.9144082.xpi", "GMail Hangouts microphone fix" intervention is no longer available in "about:compat".
https://prnt.sc/s7yq3v

Tested with:
Browser / Version: Firefox Release 76.0
Operating System: Windows 10 Pro

Comment 12

[Mike Taylor [:miketaylr]]

Thanks Oana!

Wei, can we stage the signed XPI to the test channel (release-sysaddon) for QA to re-verify?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Per discussion with Mike, we want to have this addon target Fx75 and 68.7esr users now to avoid any disruptions when the 76/68.8esr releases ship next week with the broken GMail intervention in place. Can we make the rules target 75.-76. and 68.7.-68.8., respectively?

Comment 14

[Mike Taylor [:miketaylr]]

Oops, redirecting ni? to Rehan. Please see Comments #12 and #13.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

I think we can WONTFIX this bug. I'm going to be respinning the Fx76/68.8esr RCs today to pick up a late-breaking fix. Those will also include the in-tree update of this system addon, so we should be good to go with what ships out of the box next week.

Comment 16

[Mike Taylor [:miketaylr]]

Awesome, I'll take it. Thanks for the help everyone!