Closed Bug 1633611 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 23285 - Idle: Add notification permission check

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox78 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23285 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23285
Details from upstream follow.

Ayu Ishii <ayui@chromium.org> wrote:

Idle: Add notification permission check

This change checks for notification permission before allowing
idle detection.

tested locally & wpt

Bug: 1074049
Change-Id: I5d12efaf5cb68020ed10eccf577d38319592f4f2
Reviewed-on: https://chromium-review.googlesource.com/2163638
WPT-Export-Revision: 701b0bcbebca75b852d16a82aa92f7b6a0f110a8

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 78 tests

Status Summary

Firefox

OK : 3
PASS : 69
FAIL : 4
ERROR : 6
NOTRUN: 27

Chrome

OK : 8
PASS : 88
FAIL : 2
ERROR : 1

Safari

OK : 3
FAIL : 5
ERROR : 6
NOTRUN: 27

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/idle-detection/idle-detection-allowed-by-feature-policy-attribute.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
Attribute allow="idle-detection" in top-level frame can be enabled in a worker in cross-origin iframe using Feature policy "idle-detection".: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Attribute allow="idle-detection" in top-level frame can be enabled in cross-origin iframe using Feature policy "idle-detection".: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Attribute allow="idle-detection" in top-level frame can be enabled in a worker in same-origin iframe using Feature policy "idle-detection".: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Attribute allow="idle-detection" in top-level frame can be enabled in same-origin iframe using Feature policy "idle-detection".: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/idle-detection/basics.tentative.https.window.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
constructor throws with invalid threshold (NaN): NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor uses a default value for the threshold when none is passed: NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor throws with invalid threshold (-1): NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor throws with threshold below minimum (59): NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor uses threshold property: NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor throws with invalid threshold (0): NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor throws with invalid threshold (null): NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() basics: NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor uses a default value for the threshold: NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor allows threshold (61): NOTRUN (Chrome: PASS, Safari: NOTRUN)
constructor allows threshold (60): NOTRUN (Chrome: PASS, Safari: NOTRUN)
/idle-detection/idle-detection-allowed-by-feature-policy.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
Feature-Policy {"idle-detection" : [""]} explicity set by top-level frame allows cross-origin iframes.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Feature-Policy {"idle-detection" : [""]} explicity set by top-level frame allows same-origin iframes.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Feature-Policy {"idle-detection" : [""]} explicity set by top-level frame allows the top-level document.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Feature-Policy {"idle-detection" : [""]} explicity set by top-level frame allows workers in cross-origin iframes.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Feature-Policy {"idle-detection" : ["*"]} explicity set by top-level frame allows workers in same-origin iframes.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/idle-detection/idle-permission.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Deny notifications permission should work.: FAIL (Chrome: FAIL, Safari: FAIL)
Grant notifications permission should work.: FAIL (Chrome: FAIL, Safari: FAIL)
/idle-detection/idle-detection-default-feature-policy.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
Default "idle-detection" feature policy ["self"] disallows cross-origin iframes.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Default "idle-detection" feature policy ["self"] allows same-origin iframes.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Default "idle-detection" feature policy ["self"] allows the top-level document.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/idle-detection/idle-detection-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
Attribute allow="idle-detection" in top-level frame disallows workers in cross-origin relocation.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Attribute allow="idle-detection" in top-level frame disallows cross-origin relocation.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Attribute allow="idle-detection" in top-level frame allows workers in same-origin relocation.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Attribute allow="idle-detection" in top-level frame allows same-origin relocation.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/idle-detection/idlharness-worker.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Run idlharness tests in a worker.: FAIL (Chrome: PASS, Safari: FAIL)
/idle-detection/interceptor.https.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: ERROR, Safari: ERROR)
/idle-detection/idlharness.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Test IDL implementation of Idle Detection API: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/idle-detection/idle-detection-allowed-by-feature-policy-attribute.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/idle-detection/basics.tentative.https.window.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/idle-detection/idle-detection-allowed-by-feature-policy.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/idle-detection/idle-permission.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/idle-detection/idle-detection-default-feature-policy.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/idle-detection/idle-detection-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/idle-detection/idlharness-worker.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/idle-detection/interceptor.https.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: ERROR, Safari: ERROR)
/idle-detection/idlharness.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ead62ce864f1
[wpt PR 23285] - Idle: Add notification permission check, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d318fb86b322
[wpt PR 23285] - Idle: Add notification permission check, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d318fb86b322

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.