Closed
Bug 1633675
Opened 4 years ago
Closed 4 years ago
Avoid copy of locales array in FluentBundle::Constructor
Categories
(Core :: Internationalization, task)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: sg, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Flags: needinfo?(emilio)
|
Reporter | |
Comment 1•4 years ago
|
||
Similarly, LocaleService::AssignAppLocales and LocaleService::AssignRequestedLocales could also be changed to accept rvalues, and move.
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(emilio)
|
|
Assignee | |
Comment 2•4 years ago
|
||
We were copying the string in C++, then again in Rust...
|
||
Updated•4 years ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be666717ac3b Avoid various string copies in FluentBundle constructor. r=zbraniecki
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
|
|
Assignee | |
Comment 6•4 years ago
|
||
No, I don't think we can easily avoid those.
You need to log in
before you can comment on or make changes to this bug.
Description
•