1633708 - Scrollbars overlap content in tab-modal content JS prompts/dialogs when the line cannot break

Status: RESOLVED FIXED

(Toolkit :: Notifications and Alerts, defect, P3)

Description

[Catalin Sasca, QA [:csasca]]

Attachment: Example.png

Affected versions

• Firefox 76.0b8
• Firefox Nightly 77.0a1

Affected platforms

• Windows 10 (x64)
• macOS 10.15.4
• Ubuntu 18.04 (x64)

Steps to reproduce

1. Open https://javascript.info/alert-prompt-confirm test page
2. Scroll to "Prompt" category and click on "Play" on the example
3. Input a longer value (multiply any value) in the window and click "Ok"

Expected result

• The value is properly displayed in the prompt.

Actual result

• The wrapped content is overlapped by scrollbars.

Regression range

• Will check for a regression.

Additional notes

• The issue can be seen in the attachment

Comment 1

[Matthew N. [:MattN]]

Hmm… I would have expected the behaviour to improve since bug 1583696 but that only landed in 77.

Maybe ntim sees a fix for this?

Comment 2

[:Gijs (he/him)]

I cannot reproduce the outcome in the screenshot on Windows on 76rc . The alert text is always contained in the prompt. Can you provide more detailed steps?

Comment 3

[Catalin Sasca, QA [:csasca]]

Attachment: Mac repro.mov

Sure, I'll attach a screencast with the issue. This was done on macOS 10.15.4, on Nightly 77.0a1 (2020-04-30).

Please let me know if there is something else that I can do.

Comment 4

[:Gijs (he/him)]

(In reply to Catalin Sasca, QA [:csasca] from comment #3)

Created attachment 9144704 [details]
Mac repro.mov

Sure, I'll attach a screencast with the issue. This was done on macOS 10.15.4, on Nightly 77.0a1 (2020-04-30).

Please let me know if there is something else that I can do.

I'm confused. The screencast shows the value being contained in the prompt - there's no text outside the prompt boundaries. The scrollbar overlaps it and that's not great, but otherwise things seem to be correct? Can you show the Windows behaviour from the screenshot on 76 (with text outside the prompt, overlapping the page), or was that only happening on 77?

Comment 5

[Catalin Sasca, QA [:csasca]]

It seems that 77.0a1 (2020-04-28) was affected by the outside boundaries, but the latest 77 (2020-05-03) seems to be having the same behavior as 76, on which they are affected by the scrollbar overlap.

Comment 6

[:Gijs (he/him)]

Let's keep this for the scrollbar overlap, but the text escaping is fixed, per comment #5.

Comment 7

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (non,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 8

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The priority flag is not set for this bug.
:MattN, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[Matthew N. [:MattN]]

Hi, now that parts of this are fixed can you please update the STR to focus on the remaining issue e.g. what text are you putting in the alert and how do you get the scrollbar to overlap the text?

Comment 10

[Catalin Sasca, QA [:csasca]]

Please let me know if this is ok now, Matthew.

Comment 11

[Pascal Chevrel:pascalc]

Matt, is that something we should track for 79 with a potential uplift in 78 or not? Thanks

Comment 12

[Tim Spurway [:tspurway]]

S1 or S2 bugs need an assignee - could you find someone for this bug?

Comment 13

[Matthew N. [:MattN]]

(In reply to Pascal Chevrel:pascalc from comment #11)

Matt, is that something we should track for 79 with a potential uplift in 78 or not? Thanks

This has been around for a long time IIRC. Also it seems like this issue is only when the text cannot break (e.g. no whitespace) so this probably isn't that common.

Comment 14

[Tim Nguyen :ntim]

Hi Catalin, does this look OK now? (bug 1583696 got re-landed recently with some changes)

Comment 15

[Catalin Sasca, QA [:csasca]]

Hey Tim, looks much better. Here's the attachment with the behavior on 85.0a1, under macOS 11.

Comment 16

[Tim Nguyen :ntim]

Hi, thanks for looking into it!