1633741 - Add more helpers to js::TrailingArray

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Ted Campbell [:tcampbell]]

The js::TrailingArray type was added to hold common helper methods for structures with complex trailing data.

There are more things to generalize:

• Use Checked<Offset> in instances missing it
• Add a helper for computing array length. We can overload templates that size and integer to cover the existing uses. This could assert it divides cleanly too.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633741 - Inline DefaultInitializeElements into TrailingArray. r?jandem

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633741 - Use CheckedInt for js::ImmutableScriptData. r?jandem

Cleanup the allocation of trailing arrays to use CheckedInt and follow the
example of JitScript. Remove some static_asserts that made arrays harder to
change and instead rely on the existing MOZ_ASSERT in initElements.

Depends on D72941

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633741 - Use CheckedInt for js::{Runtime,Private}ScriptData. r?jandem

Depends on D72942

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633741 - Add TrailingArray::numElements helper. r?jandem

This gives more readability to (end - start) / sizeof(T) computations to
cleanup the IonScript data type.

Depends on D72943

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41aa6a9b67e1
Inline DefaultInitializeElements into TrailingArray. r=jandem
https://hg.mozilla.org/integration/autoland/rev/666f5f689c8a
Use CheckedInt for js::ImmutableScriptData. r=jandem
https://hg.mozilla.org/integration/autoland/rev/04b81c9f1986
Use CheckedInt for js::{Runtime,Private}ScriptData. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6fae33988db5
Add TrailingArray::numElements helper. r=jandem

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/41aa6a9b67e1
https://hg.mozilla.org/mozilla-central/rev/666f5f689c8a
https://hg.mozilla.org/mozilla-central/rev/04b81c9f1986
https://hg.mozilla.org/mozilla-central/rev/6fae33988db5