1633750 - Build Bustages on ExtensionStorageComponents.h when Gecko 77 merges to Beta on 2020-05-04

Status: VERIFIED FIXED

(WebExtensions :: Storage, defect, P1)

Description

[Natalia Csoregi [:nataliaCs]]

Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=72b9a655c160339afc6ba849205b4c69bf70242e&selectedTaskRun=aKJLsZxrS0SGo_xSiWpWZA-0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299782154&repo=try&lineNumber=44068

[task 2020-04-28T13:00:15.317Z] 13:00:15 INFO - ../../../../../../../config/nsinstall -R -m 755 'GenerateOCSPResponse' '../../../../../../../dist/bin'
[task 2020-04-28T13:00:15.317Z] 13:00:15 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/manager/ssl/tests/unit/tlsserver/cmd'
[task 2020-04-28T13:00:15.317Z] 13:00:15 INFO - make[4]: Nothing to be done for 'syms'.
[task 2020-04-28T13:00:28.974Z] 13:00:28 INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/library/gtest'
[task 2020-04-28T13:00:28.975Z] 13:00:28 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fsanitize=thread -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fomit-frame-pointer -funwind-tables -fPIC -shared -Wl,--gc-sections -Wl,-h,libxul.so -o libxul.so /builds/worker/workspace/obj-build/toolkit/library/gtest/libxul_so.list -lpthread -rdynamic -fsanitize=thread -rdynamic -fuse-ld=gold -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 -Wl,--icf=safe -fstack-protector-strong -Wl,-rpath-link,/builds/worker/workspace/obj-build/dist/bin -Wl,-rpath-link,/usr/local/lib ../../../security/nss/lib/crmf/crmf_crmf/libcrmf.a ../../../js/src/build/libjs_static.a /builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/libgkrust_gtest.a ../../../config/external/nspr/pr/libnspr4.so ../../../config/external/nspr/libc/libplc4.so ../../../config/external/nspr/ds/libplds4.so ../../../config/external/lgpllibs/liblgpllibs.so ../../../security/nss/lib/nss/nss_nss3/libnss3.so ../../../security/nss/lib/util/util_nssutil3/libnssutil3.so ../../../security/nss/lib/smime/smime_smime3/libsmime3.so ../../../config/external/sqlite/libmozsqlite3.so ../../../security/nss/lib/ssl/ssl_ssl3/libssl3.so ../../../widget/gtk/mozgtk/stub/libmozgtk_stub.so ../../../widget/gtk/mozwayland/libmozwayland.so -Wl,--version-script,symverscript -lrt -lm -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lpthread -ldl -lc -lfreetype -lfontconfig -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -latk-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject -lpango-1.0 -lcairo -lgio-2.0 -lxcb-shm -lpangoft2-1.0 -lXt -lgthread-2.0
[task 2020-04-28T13:00:28.975Z] 13:00:28 ERROR - /builds/worker/workspace/obj-build/dist/include/mozilla/extensions/storage/ExtensionStorageComponents.h:30: error: undefined reference to 'NS_NewExtensionStorageSyncArea'
[task 2020-04-28T13:00:28.975Z] 13:00:28 INFO - clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2020-04-28T13:00:28.975Z] 13:00:28 INFO - /builds/worker/checkouts/gecko/config/rules.mk:608: recipe for target 'libxul.so' failed
[task 2020-04-28T13:00:28.975Z] 13:00:28 ERROR - make[4]: *** [libxul.so] Error 1
[task 2020-04-28T13:00:28.975Z] 13:00:28 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/library/gtest'
[task 2020-04-28T13:00:28.975Z] 13:00:28 INFO - /builds/worker/checkouts/gecko/config/recurse.mk:74: recipe for target 'toolkit/library/gtest/target' failed
[task 2020-04-28T13:00:28.975Z] 13:00:28 ERROR - make[3]: *** [toolkit/library/gtest/target] Error 2
[task 2020-04-28T13:00:28.975Z] 13:00:28 INFO - make[3]: *** Waiting for unfinished jobs....

Lina, could you take a look at this when you have the chance?
Backing out Bug 1626128 + Bug 1633639 + Bug 1626506 seemed to have fixed the bustage (one backed out for the failure itself, the others had to go because they caused conflicts on the backout)

Comment 1

[Lina Butler [:lina]]

Ohhh, I know what's going on there! Thanks Natalia, I should have a patch up in a bit!

How can I make a simulation build on Try? Is it mach try release?

Comment 2

[Natalia Csoregi [:nataliaCs]]

Thanks for looking into this, you can follow the steps here https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA

Comment 3

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e55e48e4ddf435048ca140a8acaa60e51cfbdf9

(I should've probably used --no-push and added just xpcshell in the UI, oops! 😬 Next time...)

Comment 4

[Lina Butler [:lina]]

Attachment: Bug 1633750 - Only build the extension storage Rust-C++ glue if `MOZ_NEW_WEBEXT_STORAGE` is enabled. r?markh!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c3414058804
Only build the extension storage Rust-C++ glue if `MOZ_NEW_WEBEXT_STORAGE` is enabled. r=markh

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0c3414058804

Comment 7

[Cosmin Sabou [:CosminS]]

Fix verified in today's beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&author=csabou%40mozilla.com&fromchange=56f7ac5216096e0cedd404ce32f2c2296ffba163&tochange=2eaf4ae7a038df49405ed53f8826aadbf163fa76&searchStr=build