Closed Bug 1633796 Opened 4 years ago Closed 4 years ago

Add an intervention for laposte.fr

Categories

(Web Compatibility :: Interventions, task, P1)

Product:
Web Compatibility
Component:
Interventions
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ksenia, Assigned: miketaylr)

References

(
URL
)

Details

This would be an intervention on mobile only. A suggested fix is in the comment

Assignee: nobody → miket
Severity: -- → N/A
Type: enhancement → task
Priority: -- → P1

Here's the original rule:

.flottingLabel .group input:focus ~ label, 
.flottingLabel .group input:valid ~ label, 
.flottingLabel .group input:read-only ~ label, 
.flottingLabel .group input.flatpickr-input ~ label,
.flottingLabel .group input:disabled ~ label {
	color:#606060; font-size:0.625em; top:0;
}

Lets inject the following:

.flottingLabel .group input:focus ~ label, 
.flottingLabel .group input:valid ~ label, 
.flottingLabel .group input:-moz-read-only ~ label,
.flottingLabel .group input.flatpickr-input ~ label,
.flottingLabel .group input:disabled ~ label {
        color:#606060; font-size:0.625em; top:0;
}

Ksenia, does that look OK?

Flags: needinfo?(kberezina)

Yeah, looks good to me!

Flags: needinfo?(kberezina)

Try run here to verify it works (it does):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3205a175047ad58f81b19ec7d923ac6937ec35b7&selectedTaskRun=NbEvHmg2TXiMgS0DIH5ywg-0

Note the lint failures due to the different prettier versions, so an esr patch will need to be careful to not include those (there's no need, the files are unrelated to these patches, I was just lazy and did git add .)

Fixed by https://hg.mozilla.org/mozilla-central/rev/bb2d9b53ac6e

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.