1633860 - title bar controls on macos firefox stay on the left in rtl mode

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[salmān]

Attachment: titlebar.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

The convention in right-to-left macOS apps is to have the titlebar controls on the upper-right corner.

Firefox keeps them on the left regardless of what direction the system is set to use. It's a minor inconsistency with the rest of the system. See attached screenshot.

(Apologies if this is not an issue or is already known!)

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[salmān]

Attachment: rtl_titlebar.png

On macOS 11 Big Sur (tested with Firefox 85) the issue seems to have regressed a bit. The zoom button and half of the minimise button have now fallen off the side.

Comment 4

[Stephen A Pohl [:spohl]]

Attachment: Bug 1633860: Place window control buttons on the right side on macOS when using an RTL system locale, regardless of the Firefox locale. r=mstange,harry,emilio

Comment 5

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:spohl, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/485629fc502f
Place window control buttons on the right side on macOS when using an RTL system locale, regardless of the Firefox locale. r=mstange,emilio,harry

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/485629fc502f

Comment 8

[Ciprian Georgiu, Desktop QA]

Reproduced this issue on macOS 11, using an affected Firefox build (75.0 Release), and by chaning the main OS language to arabic.

The issue is verified as fixed on latest Beta 94.0b6, under macOS 11.