Closed
Bug 1633885
Opened 4 years ago
Closed 4 years ago
When unfocused, the urlbar's placeholder in a new tab can get the wrong direction, flipping the text on RTL locales
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox75 | --- | unaffected |
firefox76 | --- | unaffected |
firefox77 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: mak, NeedInfo)
References
(Regression)
Details
(Keywords: regression, rtl)
Attachments
(1 file)
STR:
- Latest Nightly, install a Hebrew/Arabic lang pack to fully observe the issue
- Set
intl.uidirection
to1
and restart - Open any normal LTR url
- Open a new tab and unfocus the urlbar
- Go back to the first tab
- Go to the second tab
- Observe the url placeholder text
AR:
The text is in reverse. Focusing the urlbar makes the text readable until you unfocus.
ER:
The text should be readable and not treated as direction: ltr
.
This is caused by this:
https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/browser/base/content/browser.css#612-615
but the root of the problem is that domaindir
is still ltr
when going back to the new tab.
Assignee | ||
Comment 1•4 years ago
|
||
We should reset domaindir.
Assignee: nobody → mak
Status: NEW → ASSIGNED
Assignee | ||
Updated•4 years ago
|
Points: --- → 2
Priority: -- → P1
Assignee | ||
Updated•4 years ago
|
Iteration: --- → 77.2 - Apr 20 - May 3
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/23997add99f6 The urlbar's placeholder may be shown in the wrong locale direction. r=dao
Comment 4•4 years ago
•
|
||
Backed out changeset 23997add99f6 (Bug 1633885) for mochitest failures in layout/base/tests/test_reftests_with_caret.html CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300231264&repo=autoland&lineNumber=4306
Flags: needinfo?(mak)
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/5134e6455016 The urlbar's placeholder may be shown in the wrong locale direction. r=dao
Comment 6•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
Comment 7•4 years ago
|
||
Set release status flags based on info from the regressing bug 1623888
status-firefox75:
--- → unaffected
status-firefox76:
--- → unaffected
Fixed on latest Nightly.
Updated•4 years ago
|
status-firefox-esr68:
--- → unaffected
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•