Closed Bug 1633885 Opened 4 years ago Closed 4 years ago

When unfocused, the urlbar's placeholder in a new tab can get the wrong direction, flipping the text on RTL locales

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 77
Iteration:
77.2 - Apr 20 - May 3
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 --- verified

People

(Reporter: itiel_yn8, Assigned: mak, NeedInfo)

References

(Regression)

Details

(Keywords: regression, rtl)

Attachments

(1 file)

STR:

  1. Latest Nightly, install a Hebrew/Arabic lang pack to fully observe the issue
  2. Set intl.uidirection to 1 and restart
  3. Open any normal LTR url
  4. Open a new tab and unfocus the urlbar
  5. Go back to the first tab
  6. Go to the second tab
  7. Observe the url placeholder text

AR:
The text is in reverse. Focusing the urlbar makes the text readable until you unfocus.

ER:
The text should be readable and not treated as direction: ltr.

This is caused by this:
https://searchfox.org/mozilla-central/rev/2bfe3415fb3a2fba9b1c694bc0b376365e086927/browser/base/content/browser.css#612-615
but the root of the problem is that domaindir is still ltr when going back to the new tab.

We should reset domaindir.

Assignee: nobody → mak
Status: NEW → ASSIGNED
Points: --- → 2
Priority: -- → P1
Iteration: --- → 77.2 - Apr 20 - May 3
Flags: needinfo?(itiel_yn8)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/23997add99f6
The urlbar's placeholder may be shown in the wrong locale direction. r=dao
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/5134e6455016
The urlbar's placeholder may be shown in the wrong locale direction. r=dao
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Set release status flags based on info from the regressing bug 1623888

Fixed on latest Nightly.

Status: RESOLVED → VERIFIED
Flags: needinfo?(mak)
Blocks: 1628535
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: