1633938 - Consider implementing zoom and responsive mode interactions with transform.

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Right now RDM has a very complex handshake with the UI. As far as I can tell the idea is that zooming in and out provides a "visual zoom" of sorts so you can more closely inspect what you're doing.

Implementing this with transforms completely in the parent would both simplify the code, and avoid jumping when zooming in an out (right now there's a bit of delay since the browser zooms).

I have a WIP that seems to work alright.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1633938 - Implement RDM zoom with transform. r=bradwerth

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9144194 [details]
Bug 1633938 - Implement RDM zoom with transform. r=bradwerth

Brad, interested in your feedback.

Here's a try run you can pull builds from (as this needs probably other of my zoom patches): https://treeherder.mozilla.org/#/jobs?repo=try&revision=49376b633bc06c7c3522310e0f5d299e75c078ec

I need some more things in order for this to be reviewable:

• Fix the pieces of code I deleted and maybe shouldn't.
• Test the CSS math is right on RTL (no pun intended).
• Fix / remove tests that are no longer relevant (like the resolution test that has given me so much headache today :)).
• ... something else?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82a7f913a4537adee6b19b9ad9513ec37769bcd7

Comment 4

[Brad Werth [:bradwerth]]

Comment on attachment 9144194 [details]
Bug 1633938 - Implement RDM zoom with transform. r=bradwerth

This seems like a clever and workable solution. Thank you for doing this work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e690c4cf8848
Implement RDM zoom with transform. r=bradwerth

Comment 6

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1633938, bug 1578008, bug 1633488) for Devtool failures in browser/base/content/test/static/browser_parsable_css.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300120222&repo=autoland&lineNumber=1908

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=e690c4cf884848b968c214c38f86727ff30bc03d

Backout:
https://hg.mozilla.org/integration/autoland/rev/d3a80376591e14e1880195b31f1b2baec87f6faa

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20ac0a62f59d
Implement RDM zoom with transform. r=bradwerth

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/20ac0a62f59d