introduce HttpChannelOnStartRequestArgs
Categories
(Core :: Networking: HTTP, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: CuveeHsu, Assigned: CuveeHsu)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
We have lots of dup code for sending those args (example) and will be much more if we want to dispatch them between threads.
Assignee | ||
Comment 1•4 years ago
|
||
Note:
I was tempting to use Maybe<nsHttpResponseHead> here, but inevitably we need another copy.
On the other hand, copy constructor are called 4 times for the IPC message. Haven't taken a look to see if we can save one or two.
https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/netwerk/protocol/http/PHttpChannel.ipdl#110-111
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D73135
Assignee | ||
Comment 4•4 years ago
|
||
We have a windows build failure
The problem is we include winsock2.h which is conflict with winsock.h
Not sure if the theory is true or not:
Usually, we'll define WIN32_LEAN_AND_MEAN to minimize API in winsock.h.
However, for some reason nspr need the fullset winsock api.
And we put winsock2.h to NeckoChannelParams.ipdl, which is included in PContent, which is built too early to un-include the winsock.h
I'm going to try to have another ipdlh to avoid this. Finger crossed.
Assignee | ||
Comment 5•4 years ago
|
||
(In reply to Junior from comment #4)
We have a windows build failure
The problem is we include winsock2.h which is conflict with winsock.h
Not sure if the theory is true or not:
Usually, we'll define WIN32_LEAN_AND_MEAN to minimize API in winsock.h.
However, for some reason nspr need the fullset winsock api.
And we put winsock2.h to NeckoChannelParams.ipdl, which is included in PContent, which is built too early to un-include the winsock.hI'm going to try to have another ipdlh to avoid this. Finger crossed.
Seem working
https://treeherder.mozilla.org/#/jobs?repo=try&revision=555e316efdc476b21fa82c90acf515ee33384e7d
Assignee | ||
Comment 6•4 years ago
|
||
Pushed by juhsu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/244ef650bb0e P1 introduce HttpChannelOnStartRequestArgs and ipdl changes, r=mayhemer,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/1c0ff3fd45fa P2 pass HttpChannelOnStartRequestArgs through PHttpChannel, r=mayhemer,necko-reviewers
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/244ef650bb0e
https://hg.mozilla.org/mozilla-central/rev/1c0ff3fd45fa
Description
•