Closed Bug 1633974 Opened 4 years ago Closed 4 years ago

Find toolbar's contents get cleared when navigation causes a change in process for the tab

Categories

(Toolkit :: Find Toolbar, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla78
Fission Milestone M6a
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- verified

People

(Reporter: dholbert, Assigned: enndeakin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:
1a. Visit file:/// (or any file URI)
...or:
1b: Open a new tab.
2. Ctrl+F to find-in-page, and type something (e.g. aaa)
3. Ctrl+L to focus the URL bar, type example.org, and hit enter.

ACTUAL RESULTS:
The find bar remains open, but its contents are cleared.

EXPECTED RESULTS:
The find bar's contents should not have been cleared (since it's still open and I'm still using it).

I think this clearing is caused by a process-switch -- in this case, the switch from the dedicated file:// process or the about:newtab process to one of your other regular content processes. But as fission progresses and processes-per-origin get more numerous/granular, this will happen when you navigate between between any pair of pages whose origins differ, I imagine.

Note: If I perform a variant of my STR, with a navigation from e.g. https://example.org to https://bugzilla.mozilla.org (with findbar open with some contents before I navigate), then I get EXPECTED RESULTS with default settings vs. ACTUAL RESULTS if I enable fission.autostart; so that increases my confidence that this is a fission (process-switching) bug.)

Summary: Find toolbar's contents get cleared when navigation causes a change in prrocess → Find toolbar's contents get cleared when navigation causes a change in process for the tab

Neil, you've made the changes that made the Findbar compatible with Fission (bug 1553384), so could you take a look at this, perhaps?

Severity: -- → normal
Flags: needinfo?(enndeakin)
Priority: -- → P2
Regressed by: 1553384
Has Regression Range: --- → yes

Tracking for Fission M6a Nightly

Fission Milestone: --- → M6a
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED

I'm not sure what exactly what this code being removed does, but I don't see any issues with removing it.

I thought maybe it would cause an issue when the findbar is open and dragging the tab to a new window, but that seems to have its own problems. I filed bug 1637236 on that.

Flags: needinfo?(enndeakin)
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec9b6f1b5120
don't reset findbar when switching the findbar to a different browser, r=mikedeboer
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Flags: qe-verify+

Reproduced the issue using Firefox 77.0a1 (20200428214747) on Windows 10x64.
The issue is verified fixed with Firefox 78.0b7 (20200612174529) on Windows 10x64, macOS 10.12, and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: