Closed Bug 1633999 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23311 - [css-flexbox] Implement gap/gutters in legacy flexbox

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23311 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23311
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flexbox] Implement gap/gutters in legacy flexbox

This is primarily to support flexboxes that are laid out in legacy even
after FlexNG ships, like \<button> for which I added a test. Also
flexboxes in contenteditable or multi-column contexts.

Bug: 762679
Change-Id: Iade7f9f19db1a30b490f9d7203b72dc2275fbb0a
Reviewed-on: https://chromium-review.googlesource.com/2172758
WPT-Export-Revision: bedf8b50b44d21fa14eb2ea33f00b41a5397e571

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 110 tests and 1 subtests

Status Summary

Firefox

OK : 2[GitHub] 44[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 46[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
PASS : 2[GitHub] 152[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 155[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 28[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 29[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview]
PRECONDITION_FAILED: 8
TIMEOUT : 3
ERROR : 9[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 10[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview]
NOTRUN : 1

Chrome

OK : 2
PASS : 1
FAIL : 1

Safari

OK : 2
PASS : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/infrastructure/testdriver/actions/multiTouchPoints.html: ERROR
/infrastructure/testdriver/actions/multiTouchPointsReleaseFirstPoint.html: ERROR
/infrastructure/expected-fail/precondition.html
test: PRECONDITION_FAILED
async_test immediate: PRECONDITION_FAILED
promise_test after await: PRECONDITION_FAILED
promise_test immediate: PRECONDITION_FAILED
async_test after timeout: PRECONDITION_FAILED
/infrastructure/testdriver/actions/elementTiming.html
TestDriver actions: element timing: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
/infrastructure/testdriver/set_permission.https.html
Grant Permission for one realm: FAIL
Deny Permission, omit one realm: FAIL
/infrastructure/reftest/reftest_match_and_mismatch-5.html: FAIL
/infrastructure/expected-fail/precondition-without-setup.html: PRECONDITION_FAILED
/infrastructure/expected-fail/uncaught-exception.html: ERROR
/infrastructure/expected-fail/unhandled-rejection.html: ERROR
/infrastructure/reftest/reftest_match_and_mismatch-4.html: FAIL
/infrastructure/reftest/legacy/reftest_and_fail_0-ref.html: FAIL
/infrastructure/expected-fail/uncaught-exception-following-subtest.html: ERROR
/infrastructure/expected-fail/unhandled-rejection-following-subtest.html: ERROR
/infrastructure/reftest/reftest_match_and_mismatch-6.html: FAIL
/infrastructure/expected-fail/precondition-in-promise.html: PRECONDITION_FAILED
/infrastructure/reftest/reftest_match_and_mismatch-0.html: FAIL
/infrastructure/reftest/reftest_ref_timeout.html: TIMEOUT
/infrastructure/reftest/legacy/reftest_fuzzy_chain_ini.html: FAIL
/infrastructure/reftest/reftest_timeout.html: TIMEOUT
/infrastructure/testdriver/actions/multiTouchPointsReleaseSecondPoint.html: ERROR
/infrastructure/expected-fail/unhandled-rejection-single-test.html
Unhandled rejection in single-page test: FAIL
/infrastructure/browsers/firefox/prefs.html
Ensure that setting gecko prefs works: FAIL
/infrastructure/reftest/reftest_multiple_mismatch-0.html: FAIL
/infrastructure/testdriver/virtual_authenticator.html
Can remove a credential: FAIL
Can set user verified: FAIL
Can add a credential: FAIL
Can remove a virtual authenticator: FAIL
Can get the credentials: FAIL
Can create an authenticator: FAIL
Can remove all credentials: FAIL
/infrastructure/reftest/reftest_match_and_mismatch-1.html: FAIL
/infrastructure/reftest/legacy/reftest_cycle_fail_0-ref.html: FAIL
/infrastructure/testdriver/actions/multiTouchPointsTwoTouchStarts.html: ERROR
/infrastructure/expected-fail/timeout.html: TIMEOUT
Test that should time out: NOTRUN
/infrastructure/reftest/legacy/fuzzy-ref-2.html: FAIL
/infrastructure/testdriver/file_upload.sub.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
/infrastructure/expected-fail/failing-test.html
Failing test: FAIL
/infrastructure/reftest/reftest_match_fail.html: FAIL
/infrastructure/testdriver/generate_test_report.html
TestDriver generate_test_report method: FAIL
/infrastructure/reftest/reftest_mismatch_fail.html: FAIL
/infrastructure/reftest/reftest_multiple_mismatch-1.html: FAIL
/infrastructure/expected-fail/precondition-in-setup.html: PRECONDITION_FAILED
/infrastructure/reftest/reftest_match_and_mismatch-7.html: FAIL
/infrastructure/expected-fail/uncaught-exception-single-test.html
Uncaught exception in single-page test: FAIL
/infrastructure/testdriver/actions/multiTouchPointsWithPause.html: ERROR

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cfe4a548db9 [wpt PR 23311] - [css-flexbox] Implement gap/gutters in legacy flexbox, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51c041f58f8c [wpt PR 23311] - [css-flexbox] Implement gap/gutters in legacy flexbox, a=testonly

https://hg.mozilla.org/mozilla-central/rev/51c041f58f8c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.