16340 - mail compose window missing insert objects on toolbar

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Kathleen :Brade]

The mail compose window is missing the popup/dropdown for inserting html objects
(table, image, target, link, hrule) (as in 4.x).

Comment 1

[hangas]

Sending to JF since he owns this window.

Comment 2

[Jean-Francois Ducarroz]

you are right, it in the specs: http://gooey/client/5.0/specs/mail/Compose/Compose.html#Ender

Comment 3

[Phil Peterson]

Does mail actually own what goes into this toolbar? I would have guessed that
Ender did.

Comment 4

[Jean-Francois Ducarroz]

Ender own the javascript and the dtd that goes with the format toolbar but we have our own xul definition of it as
our toolbar is a little bit different than the editor one, we don't have the spelling button!. I just need to add few line
of XUL to fix it. Will take 5 minutes to do it...

Comment 5

[Jean-Francois Ducarroz]

comments received by email yesterday and today from [e-mail]:

This slipped through the cracks: In the web Composer, we have "insert object"
(image, hline, table, link, and named anchor) buttons on our main toolbar. But
in Mail Composer, they are in a special dropdown menu/toolbar that should
use the same icons and commands:
      <titledbutton id="imageButton"/>
      <titledbutton id="hlineButton"/>
      <titledbutton id="tableButton"/>
      <titledbutton id="linkButton"/>
      <titledbutton id="namedAnchorButton"/>

These buttons are in editorOverlay.xul, so they are already available.
You can look at the 4.x mail composer for this feature: it is at the right end
of the composer toolbar.
I was thinking that we might want to leverage the new popup menus so the text
label is also included to the right of each item, just as in the alignment
dropdown menu.

More issues: I change those icons last night to be white, since they are in the
top-most dark blue toolbar (according to the new UI look, which looks very cool,
IMHO). Thus you should set the background to that same color (#003366) so they
show up like a toolbar. I know that looks funky, maybe we should keep the
existing icons with dark background just for mail? Thus we can use them against
a standard menu background. Shuang: What
do you think?

Comment 6

[Jean-Francois Ducarroz]

I have checked in the fix but I still need cmanske to checkin the "Insert" icon
before I can close this bug...

Comment 7

[Jean-Francois Ducarroz]

The insert icon is here. Bug fixed.

Comment 8

[laurel]

OK using 12-06-08 linux 6.0 and mac OS 8.5.1.
OK using 12-02-08 nt 4.0