Closed Bug 1634130 Opened 4 years ago Closed 4 years ago

SWGL's `draw_quad_spans` will divide by zero on some quads

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: jimb, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1634130 - avoid 0-length edges in SWGL rasterizer. r?jimb
47 bytes, text/x-phabricator-request
Details | Review

If the points of a quad passed to draw_quad_spans are [(20,0), (10,10), (0,0), (10,0)], then it ends up choosing points zero and 1 as l0i and l1i. This means l0 and l1 end up with the same y, and you get a division by zero here:

https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/gfx/wr/swgl/src/gl.cc#2763

Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5dce80f2d424
avoid 0-length edges in SWGL rasterizer. r=jimb

https://hg.mozilla.org/mozilla-central/rev/5dce80f2d424

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: