1634145 - nr_ice_socket can be leaked on some types of error

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

nr_ice_sockets are owned by nr_ice_component, but there are several kinds of failure that can happen between when an nr_ice_socket is created, and when they are registered with the nr_ice_component that is supposed to own them.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd060774810e91ec4fa1de726283847dba222734&selectedTaskRun=FT27D9ULSs-Cbn4vAI0Zjw-0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=933e87852c18444668ea827c4c5cc7363beb05b5

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1634145: Avoid leaking nr_ice_sockets due to various kinds of failure. r?mjf

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3e03d6aa78d
Avoid leaking nr_ice_sockets due to various kinds of failure. r=mjf

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b3e03d6aa78d

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bwc, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Byron Campen [:bwc]]

Eh, let's uplift this.

Comment 7

[Byron Campen [:bwc]]

Comment on attachment 9144717 [details]
Bug 1634145: Avoid leaking nr_ice_sockets due to various kinds of failure. r?mjf

Beta/Release Uplift Approval Request

• User impact if declined: Potential memory leaks when using webrtc.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a leak fix, pretty straightforward.
• String changes made/needed: None.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9144717 [details]
Bug 1634145: Avoid leaking nr_ice_sockets due to various kinds of failure. r?mjf

Low risk leak fix in webrtc, uplift approved for beta, thanks!

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/15b4841e54e1