1634170 - Playing DRM Video on Android breaks non-DRM video sites.

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Randall Barker [:rbarker]]

Attachment: Logcat captured while reproducing issue.

STR:

1. Visit https://www.ezdrm.com/html/drm-demos.asp and play video
2. Open new tab and visit youtube.com
3. Play any video

Actual:
Youtube videos are broken

Expected:
Youtube videos will play

This reproduces with and DRM video such as amazon prime.
Related FxR issue: https://github.com/MozillaReality/FirefoxReality/issues/3285
The FxR issue contains a screen capture of the issue.

I was able to reproduce this in GeckoView Example.
I've attached a logcat captured while reproducing the issue.

Comment 1

[John Lin [:jhlin][:jolin]]

This problem is caused by using shared sample objects without properly clear the old crypto info of previous inputs. A regression of bug 1308405.

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1634170 - clear crypto info before reusing recycled sample. r?bryce

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/790ff6cce320
clear crypto info before reusing recycled sample. r=geckoview-reviewers,esawin

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/790ff6cce320

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jhlin, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[John Lin [:jhlin][:jolin]]

Comment on attachment 9146037 [details]
Bug 1634170 - clear crypto info before reusing recycled sample. r?bryce

Beta/Release Uplift Approval Request

• User impact if declined: DRM and non-DRM video cannot be played at the same time.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is very simple.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9146037 [details]
Bug 1634170 - clear crypto info before reusing recycled sample. r?bryce

Simple patch and Fenix should be on beta 77 soon, uplift approved for beta, thanks.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/df680cfd32ce

Comment 9

[Sorina Florean [:sflorean]]

No issue encountered while testing this issue on Android (geckoview-example app), following the steps from the description with Samsung Galaxy Note 10 (Android 10) and Nokia 6 (Android 7.1.1). The FxR issue is also verified and I will update this one as well.
Notes: Fenix issue for adding DRM support: https://github.com/mozilla-mobile/fenix/issues/1175.