Closed Bug 1634203 Opened 4 years ago Closed 4 years ago

Fix test_remote_settings_poll.js and test_remote_settings_worker.js to correctly access the RemoteSettings database

Categories

(Firefox :: Remote Settings Client, task)

Product:
Firefox
Component:
Remote Settings Client
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

Attachments

(1 file)

Bug 1634203 - Replace Kinto client with RemoteSettings client in test_remote_settings_poll
47 bytes, text/x-phabricator-request
Details | Review

After bumping the database version of RemoteSettings in https://phabricator.services.mozilla.com/D72416, those two tests started to fail because they use a Kinto client that is not necessarily compatible with the RemoteSettings database:

https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/services/settings/test/unit/test_remote_settings_poll.js#919-924

https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/services/settings/test/unit/test_remote_settings_worker.js#45-49

To be able to land the patches in bug 1620621, I'm temporarily disabling those tests, but they should be fixed and then re-enabled.

The other test was already fixed in bug 1630766.

See Also: → 1630766
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/ee3d0ac5d17f
Replace Kinto client with RemoteSettings client in test_remote_settings_poll r=glasserc

https://hg.mozilla.org/mozilla-central/rev/ee3d0ac5d17f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: