Closed Bug 1634207 Opened 2 years ago Closed 1 year ago

Add some try/CI jobs for Win7 + WebRender

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: gw, Assigned: ahal)

References

(Blocks 2 open bugs)

Details

(Whiteboard: wr-planning)

Attachments

(1 file)

It seems that we don't have any configured CI/try jobs for Windows 7 + WebRender.

We should add some, before enabling Win7 on nightly.

It would also give us some good coverage of Windows + no-DirectComposition code path.

Flags: needinfo?(jmuizelaar)
Flags: needinfo?(jbonisteel)
Blocks: wr-win7
Flags: needinfo?(jbonisteel)
Whiteboard: wr-planning
Priority: -- → P3
Severity: -- → normal

Kats, do you know what's needed to get off by default win7 CI?

Flags: needinfo?(jmuizelaar) → needinfo?(kats)

Yeah, if a test suite is restricted to the "try" project, that will prevent it from running on autoland/m-c but will still be runnable on try. An example can be seen here. We might want to further restrict it so that it doesn't show up in ./mach try fuzzy by default, but would require running ./mach try fuzzy --full for it to show up in the list. That will prevent people from accidentally include win7-qr jobs in their try pushes by using too-loose fuzzy queries. I'm not sure offhand how to do that but :ahal can probably tell us.

Flags: needinfo?(kats) → needinfo?(ahal)

Any task that doesn't run on mozilla-central will automatically need --full in |mach try fuzzy|, no extra work required. Otherwise if the task does run on central but you'd still like to require --full you can add a regex that matches your tasks here:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/target_tasks.py#20

I like to only use the latter sparingly though as it can cause developers to be backed out over things they couldn't reasonably be expected to run on try.

p.s, as I was digging into this code, I noticed a recent regression that will actually make this blacklist not work with |mach try fuzzy|. Am fixing it now.

Flags: needinfo?(ahal)

@Andrew: Would you be able to add this?

Flags: needinfo?(ahal)
No longer blocks: wr-81

Sure! So just to clarify, you want all existing Windows 7 tasks to also run with -qr on try?

Flags: needinfo?(ahal) → needinfo?(ktaeleman)
Assignee: nobody → ahal
Status: NEW → ASSIGNED

@Kats: Do we need all Win7 tasks to run with Webrender or just a subset?

Thanks Andrew!

Flags: needinfo?(ktaeleman) → needinfo?(kats)

I think if we get the same tasks that we're currently running with windows10-64-qr that should be good for now. Those are expected to be green; other suites may not be. https://searchfox.org/mozilla-central/rev/d54712b9644b49cec6cc90a9e0c325fdfab04e7c/taskcluster/ci/test/test-platforms.yml#304-306 is the set of jobs.

Flags: needinfo?(kats)

(I'll also note that windows10-64-qr/opt runs some talos and other perf tests that we can probably skip for win7, for now at least).

Sorry this slipped, will take a look today.

These tasks can only be selected on try by passing --full to |mach try fuzzy|
or |mach try chooser|. E.g:

$ ./mach try fuzzy --full -q "'windows7-32-qr"
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50146706fd41
Add some try-only windows7-32-qr test tasks, r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
See Also: → 1677233
You need to log in before you can comment on or make changes to this bug.