1634297 - [wpt-sync] Sync PR 23336 - [shadow-dom] rename slotable to slottable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23336 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23336
Details from upstream follow.

Philip Jägenstedt <[e-mail]> wrote:

[shadow-dom] rename slotable to slottable

Follows https://github.com/whatwg/dom/pull/845.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9577885510be5f30ea15fabffb68e4d81a24467

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 70 tests

Status Summary

Firefox

OK : 3
PASS: 36[GitHub] 103[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 16

Chrome

OK : 3
PASS: 52

Safari

OK : 3
PASS: 36
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/shadow-dom/slots-imperative-slot-api.tentative.html
Imperative slot API throws exception when slottable parentNode != slot's host.: FAIL (Chrome: PASS, Safari: FAIL)
Imperative slot API can assign nodes in manual slot assignment.: FAIL (Chrome: PASS, Safari: FAIL)
Moving a slot to a new host, the slot loses its previously assigned slottables.: FAIL (Chrome: PASS, Safari: FAIL)
Order and assignment of nodes are preserved during multiple assignment in a row.: FAIL (Chrome: PASS, Safari: FAIL)
Assignment with the same node in parameters should be ignored, last one wins.: FAIL (Chrome: PASS, Safari: FAIL)
Order of slottables is preserved in manual slot assignment.: FAIL (Chrome: PASS, Safari: FAIL)
attachShadow can take slotAssignment parameter.: FAIL (Chrome: PASS, Safari: FAIL)
Assigning invalid nodes causes exception and slot returns to its previous state.: FAIL (Chrome: PASS, Safari: FAIL)
A slot should be cleared of assigned nodes even if it's re-inserted into the same shadow root.: FAIL (Chrome: PASS, Safari: FAIL)
Moving a slot's tree order position within a shadow host has no impact on its assigned slottables.: FAIL (Chrome: PASS, Safari: FAIL)
Appending slottable to different host, it loses slot assignment. It can be re-assigned within a new host.: FAIL (Chrome: PASS, Safari: FAIL)
Removing a slot from DOM resets its slottable's slot assignment.: FAIL (Chrome: PASS, Safari: FAIL)
Imperative slot API throws exception when not slotAssignment != 'manual'.: FAIL (Chrome: PASS, Safari: FAIL)
Previously assigned node should not be assigned if slot moved to a new shadow root. The slot remains empty when moved back, trigger recalc.: FAIL (Chrome: PASS, Safari: FAIL)
Previously assigned slottable is moved to new slot when it's reassigned.: FAIL (Chrome: PASS, Safari: FAIL)
Previously assigned node should not be assigned if slot moved to a new shadow root. The slot remains empty when moved back, no trigger recalc.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d6082e757cb
[wpt PR 23336] - [shadow-dom] rename slotable to slottable, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4cdd5e7c02c4
[wpt PR 23336] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/370152132527
[wpt PR 23336] - [shadow-dom] rename slotable to slottable, a=testonly
https://hg.mozilla.org/integration/autoland/rev/857c51299905
[wpt PR 23336] - Update wpt metadata, a=testonly

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/370152132527
https://hg.mozilla.org/mozilla-central/rev/857c51299905