Closed Bug 1634373 Opened 4 years ago Closed 4 years ago

Add tests for role/subrole combinations for HTML and WAI-ARIA

Categories

(Core :: Disability Access APIs, task, P1)

Desktop
macOS
task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox77 --- wontfix
firefox78 --- fixed

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Whiteboard: [Mac2020_1])

Attachments

(2 files)

The patch I have adds tests for those subroles I am reasonably sure about. The SubRole method however is weird in a couple of places, for example testing for things like Note or Alert twice, but the second one is probably never reached because the first, that tests for the role attribute on the element, already covers and returns.

Attached patch WIP patchSplinter Review

Attaching my WIP patch here for safekeeping. Mozilla build environment currently doesn't let me submit to Phabricator for some reason, Python version mismatches on a large scale.

Attachment #9144764 - Attachment description: Bug 1634373 - Add tests for Mac role and subrole attributes → Bug 1634373 - Add tests for Mac role and subrole attributes, r=eeejay
Depends on: 1635184
Severity: -- → S3
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/caaa50dc6730
Add tests for Mac role and subrole attributes, r=eeejay
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: