Closed Bug 1634384 Opened 3 months ago Closed 3 months ago

Port bug 1632854: The preferences privacy page hangs if the “Use a master password” checkbox gets ticked/unticked a couple of times while the OS auth dialog is displayed

Categories

(Thunderbird :: Preferences, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Steps to reproduce

  1. Launch Thunderbird.
  2. Access the about:preferences#privacy page.
  3. Tick the “Use a master password checkbox”
  4. Ignore the OS auth prompt and tick/untick the “Use a master password” checkbox.

Expected result

  • Point 4 isn't doable.

Actual result

  • The dialog to remove the master password appears.

This fixes the issue. And as a plus, it centres the OS dialog inside of TB. This is also why I added the same to passwordManager.js.

Port of https://hg.mozilla.org/mozilla-central/rev/2569411eb193

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9144669 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9144669 [details] [diff] [review]
1634384-modal-OSKeyStore.patch

Review of attachment 9144669 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thx! r=mkmelin
Attachment #9144669 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 77.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5838625b40ad
Port bug 1632854: Pass the ChromeWindow reference to the OSKeyStore instead of the content global so the dialog will be app modal. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.