1634487 - ph signup component is not filtered out if pocket content is turned off

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

If you turn pocket off the signup component still shows in the middle of the page.

It needs to be added to the filter list.

This happened to collection to.

I think we need a better solution than a list of pocket components, but probably not something we want to fix here.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1634487 - Adding pocket signup component to list of filtered components.

Comment 2

[Scott [:thecount] Downe]

To test:

1. Setup and verify you can see signup component from https://bugzilla.mozilla.org/show_bug.cgi?id=1616997#cr-4
2. Turn off pocket from about:preferences#home

Expected: you should no longer see a signup on newtab.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23f152db8735
Adding pocket signup component to list of filtered components. r=gvn

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/23f152db8735

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (77.0a1 Build ID - 20200504093644) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.3. Now the "Newsletter Signup Snippet" component is no longer displayed if the "Recommended by Pocket" section is disabled.