1634489 - MP3 fails to play on ultimateradioshow.com

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Mike Taylor [:miketaylr]]

Originally filed at https://github.com/webcompat/web-bugs/issues/52336

STR:

1. go to https://ultimateradioshow.com/interview-with-todd-wilson-part-1/
2. click play on the <audio> controls

Expected:

Audio plays (like it does in Chrome)

Actual:

Doesn't play.

NotSupportedError: The media resource indicated by the src attribute or assigned media provider object was not suitable.
Media resource https://media.blubrry.com/uhsrnetwork/p/media.blubrry.com/fa…s.blubrry.com/uhsrnetwork/01_Todd_Wilson_Audio_Final.mp3?_=1 could not be decoded, error: Error Code: NS_ERROR_DOM_MEDIA_METADATA_ERR (0x806e0006)

mp3 is at https://media.blubrry.com/uhsrnetwork/p/media.blubrry.com/family_renewal/p/media.blubrry.com/uhsrnetwork/p/ins.blubrry.com/uhsrnetwork/01_Todd_Wilson_Audio_Final.mp3?_=1

Comment 1

[Alastor Wu [:alwu]]

NI myself for checking this issue, it looks similar with bug1566066.

Comment 2

[Alastor Wu [:alwu]]

The root cause is that, this mp3 file [1] contains two ID3v2 tag, which makes our parser confused and results in the parser being not able to find the first frame.

[1] https://media.blubrry.com/uhsrnetwork/p/media.blubrry.com/family_renewal/p/media.blubrry.com/uhsrnetwork/p/ins.blubrry.com/uhsrnetwork/01_Todd_Wilson_Audio_Final.mp3?_=1

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1634489 - allow mp3 frame parser to parse file containing multiple ID3vs tag.

Comment 4

[Alastor Wu [:alwu]]

comment2 is not a real root cause, and I'm still investigating this issue, will update more information later after I fully understand this.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1634489 - part1 : allow ID3 parser to parse multiple ID3 headers and store the latest one.

Most of time, mp3 file should only have one or none ID3v2 header, but sometime we can see a file incorrectly containing multiple ID3v2 headers where the second one is following by the first one.

Therefore, in this situation, we should keep parsing following ID3v2 header, even if we've parsed one, and report multiple headers size together in order to skip correct offset for finding the correct first frame.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1634489 - part2 : add test.

Depends on D98651

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1634489 - part3 : update ID3 link to ID3v2.4.

We've been using footer which is an attribute from v2.4, so we should keep the link up to date as well.

Depends on D98652

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d68e91869ff
part1 : allow ID3 parser to parse multiple ID3 headers and store the latest one. r=jya
https://hg.mozilla.org/integration/autoland/rev/66f2c6d5aeb3
part2 : add test. r=jya
https://hg.mozilla.org/integration/autoland/rev/b836812230d1
part3 : update ID3 link to ID3v2.4. r=jya

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d68e91869ff
https://hg.mozilla.org/mozilla-central/rev/66f2c6d5aeb3
https://hg.mozilla.org/mozilla-central/rev/b836812230d1

Comment 10

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using an old Nightly from 2020-04-29, verified that this is fixed using Firefox 85beta3 across platforms (Windows 10 64bit, macOS 11 and Ubuntu 18.04).