1634494 - Calling default action handler for `pause/stop` on those windows which doesn't have active action handlers or its media session is not active

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

Fork from bug1633565 comment1, within a page, we should treat each frame differently and call the default action handler for pause and stop if that frame doesn't have active media session or the active media session doesn't have a handler for pause or stop.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part1 : set media session active from chrome process.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part2 : only call action handler on active media session.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part3 : make content media controller per inner window.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part4 : notify media control action to the top level browsing context and all its children.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part5 : propagate action to target browsing context.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part6 : abort if we don't have any receiver.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part7 : merge 'file_media_session_page.html' to 'file_iframe_media.html'.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part8 : add test

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part1 : store the active media session context Id on WindowContext.

We determine which media session is active media session in chrome process, but the media session in content process doesn't know the detail.

This patch would store the active session context Id on the top level WindowContext, so that media session in content process can know if it's an active context or not, which helps to trigger the action handler only on active media session, after changing our propagation mechanism in following patches.

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1634494 - part5 : not always call `play` default handler

play default handler is a special case, we don't want to run it arbitrarily in order to get a better user experience.

If we have an active media session, the play should only be triggered on that session, which is something a user really wants to resume. Therefore, adding some restrictions to call default play handler only when

(1) We don't have an active media session (If we have one, the play action handler should only be triggered on that session)
(2) Active media session without setting action handler for play

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68883ad72bf2
part1 : store the active media session context Id on WindowContext. r=chunmin,farre
https://hg.mozilla.org/integration/autoland/rev/a29128465e05
part2 : only call action handler on active media session. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4df5c6612e88
part3 : make content media controller per inner window. r=chunmin,smaug
https://hg.mozilla.org/integration/autoland/rev/5560c478b424
part4 : notify media control action to the top level browsing context and all its children. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a5f8ee649ac8
part5 : not always call `play` default handler r=chunmin
https://hg.mozilla.org/integration/autoland/rev/fd7852d71376
part6 : abort if we don't have any receiver. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d8b735f11b4b
part7 : merge 'file_media_session_page.html' to 'file_iframe_media.html'. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/e1cf0bdac6b6
part8 : add test r=chunmin

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/68883ad72bf2
https://hg.mozilla.org/mozilla-central/rev/a29128465e05
https://hg.mozilla.org/mozilla-central/rev/4df5c6612e88
https://hg.mozilla.org/mozilla-central/rev/5560c478b424
https://hg.mozilla.org/mozilla-central/rev/a5f8ee649ac8
https://hg.mozilla.org/mozilla-central/rev/fd7852d71376
https://hg.mozilla.org/mozilla-central/rev/d8b735f11b4b
https://hg.mozilla.org/mozilla-central/rev/e1cf0bdac6b6