1634495 - "./mach run --debug" Fails with recent mozilla-central

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Haik Aftandilian [:haik]]

I'm running into the following failure when trying to launch Firefox via the debugger.

With the fix for bug 1632354 backed out, the command appears to work.

My repo working dir is at revision d34716786f5b.

$ ./mach run --debug
Error running mach:

['run', '--debug']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: sequence item 0: expected str instance, bytes found

File "/Users/haftandilian/r/mc/python/mozbuild/mozbuild/mach_commands.py", line 874, in run
return self._run_desktop(**kwargs)
File "/Users/haftandilian/r/mc/python/mozbuild/mozbuild/mach_commands.py", line 1158, in _run_desktop
pass_thru=True, append_env=extra_env)
File "/Users/haftandilian/r/mc/python/mach/mach/mixin/process.py", line 88, in run_process
self.log(logging.INFO, 'new_process', {'args': ' '.join(args)}, '{args}')

Comment 1

[Ricky Stewart]

Attachment: Bug 1634495 - Ensure that the debugger path is a str (instead of bytes) when running mach run debug

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1632354

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd39bdd3d90f
Ensure that the debugger path is a str (instead of bytes) when running mach run debug r=glandium

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fd39bdd3d90f

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rstewart, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Ricky Stewart]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 9

[Ricky Stewart]

Comment on attachment 9144815 [details]
Bug 1634495 - Ensure that the debugger path is a str (instead of bytes) when running mach run debug

Beta/Release Uplift Approval Request

• User impact if declined: People trying to diagnose issues when building the beta branch will have a more difficult time since they won't be able to run ./mach run --debug.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only possibly affects people using ./mach run --debug, which is already broken without this patch.
• String changes made/needed:

Comment 10

[Ricky Stewart]

The feeling is that this is nearly zero-risk and while it's not necessarily important enough to require being in the beta, it's also something that could conceivably be useful, so probably better in the beta than out.

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9144815 [details]
Bug 1634495 - Ensure that the debugger path is a str (instead of bytes) when running mach run debug

Looks safe and useful for developers on macos, approved for beta, thanks.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0790d2f662eb