1634547 - Incorrect unscrolled clip for top layer items

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Markus Stange [:mstange]]

I added a clip to top layer items in the original scrolledClip changeset which gave the items a clip to the dirtyRect. Matt then (correctly) changed this clip to be for the visibleRect, in bug 1411411.

However, I do not recall why I thought this clip was necessary. Moreover, the clip is associated with the wrong ASR: The only way this clip would make sense was if moved with the item. But it is set before we set the current ASR to the item's ASR, so it acts as a fixed clip. For scrolled top layer items (such as the dialog element, bug 1322939), this clip is just wrong.

Removing this clip doesn't seem to break anything, so I think we should just do that.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1634547 - Remove an unnecessary (and sometimes incorrect) clip. r=mattwoodrow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3396f5c4a0bc
Remove an unnecessary (and sometimes incorrect) clip. r=mattwoodrow

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3396f5c4a0bc