Closed Bug 1634591 Opened 4 years ago Closed 4 years ago

Rename nsCoreUtils::*TabDocument to *TopLevelContentDocInProcess

Categories

(Core :: Disability Access APIs, task, P3)

Product:
Core
Component:
Disability Access APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: cpeterson, Assigned: Jamie)

References

Details

Attachments

(1 file)

Bug 1634591: Rename nsCoreUtils::IsTabDocument to IsTopLevelContentDocInProcess. Rename DocAccessible::eTabDocument to eTopLevelContentDocInProcess.
47 bytes, text/x-phabricator-request
Details | Review

Jamie recommended the following renamings in bug 1573630 comment 3:

  1. Rename IsTabDocument to IsTopLevelContentDocInProcess.
  2. Rename eTabDocument to eTopLevelContentDocInProcess.
  3. In the Windows code, add assertions that all uses of both of these are in the parent process.
Priority: -- → P3
Blocks: a11y-fission
Depends on: 1644319
Blocks: 1573630

This also adds some assertions where these are used in the Windows code, as it would be bad if that code ran in an OOP iframe document.

Assignee: nobody → jteh
Status: NEW → ASSIGNED
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/444d6a4f06a5
Rename nsCoreUtils::IsTabDocument to IsTopLevelContentDocInProcess. Rename DocAccessible::eTabDocument to eTopLevelContentDocInProcess. r=MarcoZ

https://hg.mozilla.org/mozilla-central/rev/444d6a4f06a5

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: