1634643 - Warning: Failed prop type: The prop `stacktrace` is marked as required in `StackTrace`, but its value is `null`.

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Load http://janodvarko.cz/firebug/tests/601/Issue601.htm
2. Open DevTools and select the Network panel
3. Click the POST button on the page to generate a request
4. Select the request and pick Resend
5. Click the new request to open the side bar and select the Stack Trace panel

Check out the Browser Console for the following error:

Warning: Failed prop type: The prop `stacktrace` is marked as required in `StackTrace`, but its value is `null`.
    in StackTrace (created by StackTracePanel)
    in StackTracePanel (created by TabboxPanel)
    in div (created by Panel)
    in Panel (created by TabboxPanel)
    in div (created by Tabs)
    in div (created by Tabs)
    in div (created by Tabs)
    in Tabs (created by Sidebar)
    in Sidebar (created by Tabbar)
    in div (created by Tabbar)
    in Tabbar (created by TabboxPanel)
    in TabboxPanel (created by NetworkDetailsBar)
    in div (created by NetworkDetailsBar)
    in NetworkDetailsBar
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by MonitorPanel)
    in div (created by SplitBox)
    in div (created by SplitBox)
    in SplitBox (created by MonitorPanel)
    in div (created by MonitorPanel)
    in MonitorPanel
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by App)
    in div (created by DropHarHandler)
    in DropHarHandler (created by App)
    in div (created by App)
    in App
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component)
    in Provider react-dev.js:2726:15

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Bomsy, this could be easy to fix.

Honza

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:Honza, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't see it in 76, so looks like a regression.

Honza

Comment 4

[Hubert Boma Manilla (:bomsy)]

Yes its a regression. looking into it now.

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1634643 - Make sure array is passed to stacktrace r=honza

Default set stacktrace to [] if its falsy
Added check for empty array ahead to return early

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hard to test using mozregression since a special flag needs to be added into the .mozconfig file ac_add_options --enable-debug-js-modules
The attached patch fixes the problem so we seem to be good here.

Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3b0b878f7c1
Make sure array is passed to stacktrace r=Honza

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d3b0b878f7c1