1634696 - Fix a crash on DX12 Adapter destruction in WebGPU

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P2)

Description

[Dzmitry Malyshau [:kvark]]

See https://treeherder.mozilla.org/logviewer.html#?job_id=300277360&repo=try

[task 2020-04-30T19:48:04.668Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.668Z] 19:48:04     INFO - 13  xul.dll!MessageLoop::DoWork() [message_loop.cc:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 523 + 0x38]
[task 2020-04-30T19:48:04.668Z] 19:48:04     INFO -     rsp = 0x000000eb10bff360   rip = 0x00007ffbe03a864f
[task 2020-04-30T19:48:04.668Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.669Z] 19:48:04     INFO - 14  xul.dll!base::MessagePumpForUI::DoRunLoop() [message_pump_win.cc:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 203 + 0x9]
[task 2020-04-30T19:48:04.669Z] 19:48:04     INFO -     rsp = 0x000000eb10bff400   rip = 0x00007ffbe0393a29
[task 2020-04-30T19:48:04.669Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.669Z] 19:48:04     INFO - 15  xul.dll!base::MessagePumpWin::Run(base::MessagePump::Delegate*) [message_pump_win.h:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 79 + 0x6d]
[task 2020-04-30T19:48:04.669Z] 19:48:04     INFO -     rsp = 0x000000eb10bff4d0   rip = 0x00007ffbe03947bd
[task 2020-04-30T19:48:04.669Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.670Z] 19:48:04     INFO - 16  xul.dll!MessageLoop::RunHandler() [message_loop.cc:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 308 + 0x8]
[task 2020-04-30T19:48:04.670Z] 19:48:04     INFO -     rsp = 0x000000eb10bff530   rip = 0x00007ffbe03a74a0
[task 2020-04-30T19:48:04.670Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.670Z] 19:48:04     INFO - 17  xul.dll!base::Thread::ThreadMain() [thread.cc:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 192 + 0x6b]
[task 2020-04-30T19:48:04.670Z] 19:48:04     INFO -     rsp = 0x000000eb10bff580   rip = 0x00007ffbe03b1e4e
[task 2020-04-30T19:48:04.670Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO - 18  xul.dll!`anonymous namespace'::ThreadFunc(void*) [platform_thread_win.cc:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 19 + 0x6]
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO -     rsp = 0x000000eb10bff7a0   rip = 0x00007ffbe039528a
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO - 19  kernel32.dll!guard_dispatch_icall_nop + 0x86d4
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO -     rsp = 0x000000eb10bff7d0   rip = 0x00007ffc2c603034
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.671Z] 19:48:04     INFO - 20  xul.dll + 0x985280
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO -     rsp = 0x000000eb10bff7f8   rip = 0x00007ffbe0395280
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO -     Found by: stack scanning
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO - 21  mozglue.dll!patched_BaseThreadInitThunk(int, void*, void*) [WindowsDllBlocklist.cpp:d1f6d4209dbe2c1a8402abbf456d3916e97d6533 : 592 + 0xe]
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO -     rsp = 0x000000eb10bff800   rip = 0x00007ffc146f8d8d
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO -     Found by: stack scanning
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO - 22  ntdll.dll!guard_dispatch_icall_nop + 0x66b01
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO -     rsp = 0x000000eb10bff870   rip = 0x00007ffc2e941461
[task 2020-04-30T19:48:04.672Z] 19:48:04     INFO -     Found by: call frame info
[task 2020-04-30T19:48:04.673Z] 19:48:04     INFO - 23  KERNELBASE.dll!guard_dispatch_icall_nop + 0xe15b0
[task 2020-04-30T19:48:04.673Z] 19:48:04     INFO -     rsp = 0x000000eb10bff8a0   rip = 0x00007ffc2b7ebf10
[task 2020-04-30T19:48:04.673Z] 19:48:04     INFO -     Found by: stack scanning

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Bump gfx-backend-dx12 dependency to 0.5.1

the drop order of adapter fields made it so the handle to DX12 DLL was dropped before
the last resources are destroyed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28142bfa0418
Bump gfx-backend-dx12 dependency to 0.5.1 r=groves

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/28142bfa0418