16348 - [MLK] COOKIE_GetCookie() leaks

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P2)

Description

[Robert John Churchill]

The function COOKIE_GetCookie() leaks memory under certain situations. One of the
first things it does is call  cookie_ParseURL()  twice to get "host" and "path"
strings. These strings end up being allocated via calls to PL_strdup().

However, COOKIE_GetCookie() has situations where it just "return"s in the middle
of the function without calling PR_Free().  [Note: both "host" and "path"
variables are PR_Free()'ed at the end of the function, if it reaches the end.]

Please either use PR_Free() for "host" and "path" at every "return" point in the
GetCookie() function, or rewrite the function to not "return" anywhere in the
middle of the routine's execution, so that the PR_Free()s at the end have a
chance to free up the memory leaks.

Also, it might be good to add some more NULL checking, as either "host" or "path"
could be NULL.

[Note: Leaks found using beard's Boehm GC.]

Comment 1

[Stephen P. Morse]

*** Bug 16392 has been marked as a duplicate of this bug. ***

Comment 2

[Tom Everingham]

Steve, do you know if 16348 (this bug) and dup 16392 have been
addressed and if so can you mark this verified?  I don't have a
mem leak tool readily available.

Comment 3

[Stephen P. Morse]

Yes, they have been fixed.  Marking verified as per your instructions.  But this
feels like cheating since I'm the one who fixed it and now I'm verifying my own
fix.

Comment 4

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/66e76ef5f6c4
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/16348 - Increase Gradle daemon memory size (https://github.com/mozilla-mobile/fenix/pull/16349)