Closed Bug 1634809 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 23375 - [client hints] Accept-CH should override, not merge; including ""

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23375 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23375
Details from upstream follow.

Maks Orlovich <morlovich@chromium.org> wrote:

[client hints] Accept-CH should override, not merge; including ""

Change-Id: I5c3c94023b10b265e63a8abe29a431bd1da8dadf
Reviewed-on: https://chromium-review.googlesource.com/2093032
WPT-Export-Revision: b940ed30405b91531d70015d2ffc873db01f6c01

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 91 tests and 2 subtests

Status Summary

Firefox

OK : 20
PASS: 51[GitHub] 119[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 7[GitHub] 10[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 20
PASS: 56
FAIL: 2

Safari

OK : 20
PASS: 51
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/accept-ch-stickiness/cross-origin-subresource-with-feature-policy.https.html
cross origin subresources authorized by FP gets it own resources got client hints according to expectations.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-navigation-redirect.https.html
redirect on navigation got client hints according to expectations.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-stickiness/http-equiv-same-origin-navigation.https.html
http-equiv same origin navigation got client hints according to expectations.: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [GitHub] (Chrome: PASS, Safari: PASS)
/client-hints/accept-ch-stickiness/http-equiv-cross-origin-navigation.https.html
http-equiv cross origin navigation got client hints according to expectations.: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [GitHub] (Chrome: PASS, Safari: PASS)
/client-hints/accept-ch-stickiness/http-equiv-same-origin-iframe.https.html
http-equiv same origin iframe got client hints according to expectations.: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [GitHub] (Chrome: PASS, Safari: PASS)
/client-hints/accept-ch-stickiness/same-origin-navigation.https.html
same origin navigation got client hints according to expectations.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-navigation-no-accept-ch.https.html
empty-ch on navigation got client hints according to expectations.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-iframe.https.html
same origin iframe got client hints according to expectations.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-stickiness/cross-origin-navigation.https.html
cross origin navigation got client hints according to expectations.: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/http-equiv-accept-ch-merge.https.html
Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5508be2b8350
[wpt PR 23375] - [client hints] Match update behavior to the spec., a=testonly
https://hg.mozilla.org/integration/autoland/rev/25ec2130b06e
[wpt PR 23375] - Update wpt metadata, a=testonly
Status: REOPENED → RESOLVED
Closed: 1 year ago11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.